Skip to content

feat(mcp): re-enable oauth resource parameter and add discovery logging #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jrf0110 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(mcp): re-enable oauth resource parameter and add discovery logging #5331

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/services/mcp/oauth/McpAuthorizationDiscovery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,6 +158,7 @@ export class McpAuthorizationDiscovery {
}
} catch (e) {
// Ignore and try next
console.warn(`Failed to fetch RFC 8414 metadata:`, e)
}

// Try OIDC Discovery
Expand All @@ -174,6 +175,7 @@ export class McpAuthorizationDiscovery {
}
} catch (e) {
// Ignore fetch errors
console.warn(`Failed to fetch OIDC metadata:`, e)
}

throw new Error(`Failed to discover authorization server metadata for ${issuerUrl}`)
Expand Down
2 changes: 1 addition & 1 deletion src/services/mcp/oauth/McpOAuthService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ export class McpOAuthService {
state,
codeChallenge,
codeChallengeMethod: "S256",
// resource: serverUrl, // Disabled: Cloudflare doesn't support RFC 8707 resource parameter
resource: serverUrl,
})

// 5. Verify State
Expand Down