fix(agent-manager): display pasted images in message list #5354
+64
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add MessageThumbnails component using agent manager's vscode utility - Render images in user_feedback messages - Render images in queued messages - Avoid VS Code API conflict with main webview's Thumbnails component
🦋 Changeset detectedLatest commit: 82bf509 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge The PR adds image thumbnail display functionality to the Agent Manager message list. The implementation is clean and follows React best practices:
Files Reviewed (3 files)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed broken image display in Agent Manager message list. Images pasted or attached to messages now render correctly as thumbnails.
Problem
When users pasted images in the Agent Manager, the images would show as broken/missing in the message list.
Root Cause
MessageList.tsxwas not rendering images attached to messagesThumbnailscomponent imports from@src/utils/vscodewhich creates a singleton that callsacquireVsCodeApi()immediately. This conflicts with the agent manager's own vscode utility.Solution
MessageThumbnailscomponent that uses the agent manager's vscode utility to avoid the API conflictuser_feedbackmessagesQueuedMessageItemfor queued messagesTesting