Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] product_template_tags: DEPRECATED #5

Open
wants to merge 54 commits into
base: 18.0
Choose a base branch
from

Conversation

Kimkhoi3010
Copy link
Owner

@Kimkhoi3010 Kimkhoi3010 commented Dec 3, 2024

In Odoo 16, a new standard model called product_tag was introduced in the product module, which serves the same purpose as the deprecated product_template_tags model.
So removing this module causes no harm.

patrickrwilson and others added 30 commits December 3, 2024 18:23
[UPD] Suggested Changes

Updated code based on reviews

[UPD] Add readme folder

Added readme folder and made it so tags can be colored.

[UPD] Aesthetic Changes

Aesthetic changes requested from reviewer.

[UPD] README.rst

[UPD] Update product_template_tags.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-12.0/product-attribute-12.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_template_tags/

[UPD] README.rst
[UPD] Update product_template_tags.pot
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-13.0/product-attribute-13.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_template_tags/
Currently translated at 100.0% (17 of 17 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_template_tags/es/
Currently translated at 100.0% (17 of 17 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_template_tags/de/
Currently translated at 100.0% (17 of 17 strings)

Translation: product-attribute-13.0/product-attribute-13.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-13-0/product-attribute-13-0-product_template_tags/fr/
The tag.products_count field was store=True
If more than one user is adding/removing the same tag to different products
at the same time it will raise concurrencies issues

In fact, if you are configuring/importing your products
this compute could be so slow
Since that each tag will be updated for each product

It was changed to store=False in order to avoid these issues.

The tag.products_count field is displayed in tree view
So it needs to be so faster
Then the compute was changed using a query directly with "group by"
in order to process it faster
avoid return if nothing to compute to be compliant with new ORM compute field method
Currently translated at 100.0% (17 of 17 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_template_tags/nl_NL/
Currently translated at 100.0% (18 of 18 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_template_tags/nl/
* Improve tags form view
* Improve tags search view: company_id should only be visible in case of multi-company
* Improve tree view: Replace products_count with color
* Improve product kanban's views
* Add a kanban view for product.product
* Add missing xml header in xml files
* Rename field from 'Product Tags' to 'Tags'
This should be handled in glue modules for each
Sale, Purchase and Inventory apps.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-14.0/product-attribute-14.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_template_tags/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_template_tags/it/
BT-dmontull and others added 24 commits December 3, 2024 18:36
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_template_tags/ca/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_template_tags/pt/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_template_tags/it/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/it/
Currently translated at 100.0% (19 of 19 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/
Currently translated at 100.0% (23 of 23 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/it/
Currently translated at 73.9% (17 of 23 strings)

Translation: product-attribute-16.0/product-attribute-16.0-product_template_tags
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_template_tags/hr/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.