call sessionBusy false at end of getServerInfo. added tests (#3219)

* call sessionBusy false at end of getServerInfo. added tests * ran format
Kinto · Apr 17, 2024 · 7fc445c · 7fc445c
1 parent 3a95325
commit 7fc445c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/src/sagas/session.ts b/src/sagas/session.ts
@@ -92,6 +92,7 @@ export function* getServerInfo(
       )
     );
   }
+  yield put(actions.sessionBusy(false));
 }
 
 export function* setupSession(

diff --git a/test/sagas/session_test.ts b/test/sagas/session_test.ts
@@ -97,6 +97,10 @@ describe("session sagas", () => {
         expect(getServerInfo.next(serverInfo).value).toMatchObject(
           put(actions.serverInfoSuccess(serverInfo))
         );
+        // ensure that sessionBusy is called
+        expect(getServerInfo.next().value).toStrictEqual(
+          put(actions.sessionBusy(false))
+        );
       });
 
       it("should split the auth if it's openID", () => {
@@ -140,6 +144,10 @@ describe("session sagas", () => {
           "Could not reach server http://server.test/v1",
           undefined
         );
+        // ensure that sessionBusy is called
+        expect(getServerInfo.next().value).toStrictEqual(
+          put(actions.sessionBusy(false))
+        );
       });
     });
-Original file line number
+Diff line change
@@ Expand Up / @@ -92,6 +92,7 @@ export function* getServerInfo( @@
           )
         );
       }
+      yield put(actions.sessionBusy(false));
     }
     export function* setupSession(
@@ Expand Down @@