Fixes #2506 - Updating react codemirror package that we use #3077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto issue-3073
leplatrem
reviewed
Nov 30, 2023
src/App.tsx
Outdated
| @@ -4,7 +4,7 @@ import { Provider } from "react-redux"; | |||
|
|
|||
| import { store, history } from "./store/configureStore"; | |||
| import "bootstrap/dist/css/bootstrap.css"; | |||
| import "codemirror/lib/codemirror.css"; | |||
| // import "codemirror/lib/codemirror.css"; | |||
There was a problem hiding this comment.
not necessary anymore? Shall we just remove it?
There was a problem hiding this comment.
Yup, missed that one.
src/components/JSONEditor.tsx
Outdated
| height="auto" | ||
| style={{}} | ||
| extensions={[langs.json()]} | ||
| indentWithTab={true} |
There was a problem hiding this comment.
We had indentWithTabs: false, with options like tabSize: 2,. Why this change?
There was a problem hiding this comment.
Ah, that was my bad. I also had an empty style object in there because I wasn't sure if I was going to need to tweak things.
Switched indentWithTabs to false. Indentation size appears to be 2 by default so I didn't try to change it. But if we want to, it looks like we set that in extensions.
leplatrem
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2506. Be sure to review #3076 first as this is branched from that.
Switching to a react codemirror package that supports codemirror v6. Differences are subtle but present. Would like to hear any objections over using this package, but it seems solid to me.
New
Old
