Migrate all remaining JS files to TS, tweak ESLint and Typescript configuration #3141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use esnext consistently in tsconfig.json Add vitest globals to tsconfig types Include src and test directories in tsconfig Split tsconfig into separate files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
{js, jsx}files to{ts, tsx}In playing around with this configuration, I discovered that we're missing a lot of the type safety that Typescript should provide as well as some important React rules. I turned of some ESLint rules in this PR with the plan of re-enabling them in future PRs. See #3140 and #2132