Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #915: Add button to copy authentication header #929

Merged
merged 2 commits into from
May 29, 2019

Conversation

leplatrem
Copy link
Contributor

@leplatrem leplatrem commented May 28, 2019

Fix #915

Screenshot from 2019-05-28 13-23-37

/cc @ncloudioj

@leplatrem leplatrem requested a review from glasserc May 28, 2019 11:23
@leplatrem leplatrem force-pushed the 915-copy-bearer-token branch from 89bd0a7 to 8b16ee0 Compare May 28, 2019 13:30
@leplatrem
Copy link
Contributor Author

Screenshot from 2019-05-28 16-06-57

Don't know how to get out of this with flow. Giving up for today

Copy link
Contributor

@glasserc glasserc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks much better, I'm glad you took the time to do this.

@leplatrem leplatrem force-pushed the 915-copy-bearer-token branch from 5bfcce4 to 66535a5 Compare May 29, 2019 14:44
@leplatrem leplatrem merged commit 40afc88 into master May 29, 2019
@leplatrem leplatrem deleted the 915-copy-bearer-token branch May 29, 2019 14:45
@vanillajonathan
Copy link
Contributor

The button is visible even when using anonymous authentication where there is nothing copy.

@leplatrem
Copy link
Contributor Author

@vanillajonathan Thanks for reporting this! Would you mind opening a new issue or pull-request so that we can track its resolution? Thx

@vanillajonathan
Copy link
Contributor

@leplatrem Sure. Created issued #1267.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add button to copy Authorization header value to the clipboard
4 participants