Skip to content

[Button] Change font size on regular size and up #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joachimesque wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Button] Change font size on regular size and up #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2ae438
[Button] Change font size on `regular` size and up
joachimesque Feb 15, 2022
4ce0490
Update standalone-styles.js
joachimesque Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ This project adheres to [Semantic Versioning](http://semver.org/).

## [unreleased]

- Fix: `Button`: Change font size on `regular` size and up.

## [8.4.0] - 2022-02-14

Features:
Expand Down
12 changes: 4 additions & 8 deletions assets/javascripts/kitten/components/action/button-group/__snapshots__/test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
gap: 0.625rem;
font-family: Maax,Helvetica,Arial,sans-serif;
font-weight: 500;
font-size: 0.875rem;
font-size: 1rem;
color: var(--color-grey-900,#222);
line-height: 1.3;
-webkit-text-decoration: none;
Expand Down Expand Up @@ -76,6 +76,7 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-dimension: 2.5rem;
--Button-min-width: 10rem;
--Button-padding: 0.4375rem 1.25rem;
font-size: 0.875rem;
}

.c1.k-Button--regular {
Expand Down Expand Up @@ -170,7 +171,7 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
gap: 0.625rem;
font-family: Maax,Helvetica,Arial,sans-serif;
font-weight: 500;
font-size: 0.875rem;
font-size: 1rem;
color: var(--color-grey-900,#222);
line-height: 1.3;
-webkit-text-decoration: none;
Expand Down Expand Up @@ -224,6 +225,7 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-dimension: 2.5rem;
--Button-min-width: 10rem;
--Button-padding: 0.4375rem 1.25rem;
font-size: 0.875rem;
}

.c2.k-Button--regular {
Expand Down Expand Up @@ -348,7 +350,6 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 4.375rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand All @@ -357,7 +358,6 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 5rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand All @@ -366,7 +366,6 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 5.625rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand Down Expand Up @@ -400,7 +399,6 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 4.375rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand All @@ -409,7 +407,6 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 5rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand All @@ -418,7 +415,6 @@ exports[`<ButtonGroup /> with some props matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 5.625rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand Down
18 changes: 9 additions & 9 deletions assets/javascripts/kitten/components/action/button-icon/__snapshots__/test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`<ButtonIcon /> by default matches with snapshot 1`] = `
<button
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
style={
Object {
"--Button-border-radius": null,
Expand All @@ -18,7 +18,7 @@ exports[`<ButtonIcon /> by default matches with snapshot 1`] = `

exports[`<ButtonIcon /> className prop matches with snapshot 1`] = `
<button
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon test_className_prop k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon test_className_prop k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
style={
Object {
"--Button-border-radius": null,
Expand All @@ -34,7 +34,7 @@ exports[`<ButtonIcon /> className prop matches with snapshot 1`] = `

exports[`<ButtonIcon /> modifier prop matches with snapshot 1`] = `
<button
className="sc-bdvvtL ea-dQkw k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--helium k-Button--fit-icon"
className="sc-bdvvtL cNriUc k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--helium k-Button--fit-icon"
style={
Object {
"--Button-border-radius": null,
Expand All @@ -50,7 +50,7 @@ exports[`<ButtonIcon /> modifier prop matches with snapshot 1`] = `

exports[`<ButtonIcon /> rounded prop matches with snapshot 1`] = `
<button
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon k-Button--rounded"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon k-Button--rounded"
style={
Object {
"--Button-border-radius": null,
Expand All @@ -66,7 +66,7 @@ exports[`<ButtonIcon /> rounded prop matches with snapshot 1`] = `

exports[`<ButtonIcon /> size prop matches with snapshot 1`] = `
<button
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--nano k-Button--nano k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--nano k-Button--nano k-Button--hydrogen k-Button--fit-icon"
style={
Object {
"--Button-border-radius": null,
Expand All @@ -82,7 +82,7 @@ exports[`<ButtonIcon /> size prop matches with snapshot 1`] = `

exports[`<ButtonIcon /> tag prop matches with snapshot 1`] = `
<span
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
disabled={null}
style={
Object {
Expand All @@ -99,7 +99,7 @@ exports[`<ButtonIcon /> tag prop matches with snapshot 1`] = `

exports[`<ButtonIcon /> with tag="a" and no href matches with snapshot 1`] = `
<a
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
disabled={null}
style={
Object {
Expand All @@ -116,7 +116,7 @@ exports[`<ButtonIcon /> with tag="a" and no href matches with snapshot 1`] = `

exports[`<ButtonIcon /> with tag="a" href="foo" matches with snapshot 1`] = `
<a
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
disabled={null}
href="foo"
style={
Expand All @@ -134,7 +134,7 @@ exports[`<ButtonIcon /> with tag="a" href="foo" matches with snapshot 1`] = `

exports[`<ButtonIcon /> without children matches with snapshot 1`] = `
<button
className="sc-bdvvtL gdafnu k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
className="sc-bdvvtL iMtDta k-Button sc-gsDKAQ jHnLLM k-ButtonIcon k-ButtonIcon--regular k-Button--regular k-Button--hydrogen k-Button--fit-icon"
style={
Object {
"--Button-border-radius": null,
Expand Down
2 changes: 1 addition & 1 deletion ...javascripts/kitten/components/action/button-question-mark-icon/__snapshots__/test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

exports[`ButtonQuestionMarkIcon /> default snapshot 1`] = `
<button
className="sc-bdvvtL ea-dQkw k-Button k-Button--nano k-Button--helium k-Button--fit-icon k-Button--rounded"
className="sc-bdvvtL cNriUc k-Button k-Button--nano k-Button--helium k-Button--fit-icon k-Button--rounded"
style={
Object {
"--Button-border-radius": null,
Expand Down
6 changes: 2 additions & 4 deletions assets/javascripts/kitten/components/action/button-with-tooltip/__snapshots__/test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ exports[`<ButtonWithTooltip /> basic matches with snapshot 1`] = `
gap: 0.625rem;
font-family: Maax,Helvetica,Arial,sans-serif;
font-weight: 500;
font-size: 0.875rem;
font-size: 1rem;
color: var(--color-grey-900,#222);
line-height: 1.3;
-webkit-text-decoration: none;
Expand Down Expand Up @@ -185,6 +185,7 @@ exports[`<ButtonWithTooltip /> basic matches with snapshot 1`] = `
--Button-dimension: 2.5rem;
--Button-min-width: 10rem;
--Button-padding: 0.4375rem 1.25rem;
font-size: 0.875rem;
}

.c1.k-Button--regular {
Expand Down Expand Up @@ -308,7 +309,6 @@ exports[`<ButtonWithTooltip /> basic matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 4.375rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand All @@ -317,7 +317,6 @@ exports[`<ButtonWithTooltip /> basic matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 5rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand All @@ -326,7 +325,6 @@ exports[`<ButtonWithTooltip /> basic matches with snapshot 1`] = `
--Button-min-width: 13.75rem;
--Button-dimension: 5.625rem;
--Button-padding: 0.625rem 2.5rem;
font-size: 1rem;
}
}

Expand Down
Loading