[WIP] DCC Chat/Send #138

octylFractal · 2016-09-15T17:29:01Z

It's probably robust, but the code style needs work.

This closes #93.

Things to do:

codecov-io · 2016-09-15T17:31:53Z

Current coverage is 32.46% (diff: 0.00%)

Merging #138 into master will decrease coverage by 1.40%

@@             master       #138   diff @@
==========================================
  Files           139        146     +7   
  Lines          3460       3610   +150   
  Methods           0          0          
  Messages          0          0          
  Branches        498        502     +4   
==========================================
  Hits           1172       1172          
- Misses         2258       2408   +150   
  Partials         30         30

Powered by Codecov. Last update 36075de...ad9896f

Zarthus · 2016-09-15T17:34:59Z

Is the class naming in line for what KICL generally uses?

I'd imagine the classes should be named 'IrcDcc' etc. Because the ISupport class follows the same pattern.

octylFractal · 2016-09-15T17:36:57Z

IRC is convention:

Not sure about DCC, could be changed to Dcc.

Zarthus · 2016-09-15T17:37:01Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java


 final class NettyManager {
+


Looks like your IDE is conflicting with Mbaxter's. I don't really care, but it might be useful to ensure you've got the same code style configuration as him later.

Zarthus · 2016-09-15T17:37:42Z

src/main/java/org/kitteh/irc/client/library/implementation/EventListener.java

@@ -977,6 +977,12 @@ public void ctcp(ClientReceiveCommandEvent event) {
                        case "FINGER":
                            reply = "FINGER om nom nom tasty finger";
                            break;
+                        case "DCC":


Missing break?

It falls ~~through~~ out (it's the last one), plus there's the entire comment below it :)

Sounds like bad coding practice to me. I thought the primary use of that was to make more than one case statement apply.

There's no break needed on the last statement...what would that accomplish?

It's got a break. Let me have a break.

kashike

Some things to fix.

kashike · 2016-09-15T17:31:50Z

src/main/java/org/kitteh/irc/client/library/Client.java

@@ -23,6 +23,17 @@
 */
 package org.kitteh.irc.client.library;

+import java.io.File;


You rearranged the imports.

kashike · 2016-09-15T17:32:35Z

src/main/java/org/kitteh/irc/client/library/element/DCCChat.java

+import javax.annotation.Nonnull;
+
+public interface DCCChat extends DCCExchange {
+


No empty line at the start of the class.

kashike · 2016-09-15T17:33:20Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+     * 
+     * @return the socket address of the local end
+     */
+    SocketAddress getLocalSocket();


Should be getLocalSocketAddress.

kashike · 2016-09-15T17:33:32Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+     * 
+     * @return the socket address of the remote end
+     */
+    SocketAddress getRemoteSocket();


Should be getRemoteSocketAddress.

kashike · 2016-09-15T17:40:55Z

src/main/java/org/kitteh/irc/client/library/element/DCCChat.java

+     *            the message to send
+     */
+    void sendMessage(@Nonnull String message);
+


No empty line at the end of the class.

kashike · 2016-09-15T17:44:20Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+    }
+
+    class IRCDCCChatSnapshot extends IRCDCCExchangeSnapshot implements DCCChat {
+


No empty line at the start of the class.

kashike · 2016-09-15T17:44:31Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+
+        @Override
+        public void sendMessage(String message) {
+            this.nettyChannel.writeAndFlush(message.trim());


message should be validated.

kashike · 2016-09-15T17:44:34Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        public void sendMessage(String message) {
+            this.nettyChannel.writeAndFlush(message.trim());
+        }
+


No empty line at the end of the class.

kashike · 2016-09-15T17:44:53Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

@@ -23,7 +23,40 @@
 */
 package org.kitteh.irc.client.library.implementation;

+import java.io.File;


You rearranged the imports.

kashike · 2016-09-15T17:45:09Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

@@ -256,7 +283,11 @@ private void schedule(boolean force) {
                }
                long delay = 0;
                if (this.scheduledSending != null) {
-                    delay = this.scheduledSending.getDelay(TimeUnit.MILLISECONDS); // Negligible added delay processing this
+                    delay = this.scheduledSending.getDelay(TimeUnit.MILLISECONDS); // Negligible


kashike · 2016-09-15T17:59:18Z

src/main/java/org/kitteh/irc/client/library/Client.java

@@ -829,4 +829,7 @@ default void sendMultiLineNotice(@Nonnull MessageReceiver target, @Nonnull Strin
     * @param reason quit message to send
     */
    void shutdown(@Nonnull String reason);
+
+    @Nonnull
+    void beginDCCChat(@Nonnull User target);


Missing javaducks.

kashike · 2016-09-15T18:01:02Z

src/main/java/org/kitteh/irc/client/library/element/User.java

@@ -100,4 +102,15 @@
     * @return true if away
     */
    boolean isAway();
+
+    /**
+     * Begins a DCC chat with this user. When the chat is connected,


/** * Begins a DCC chat with this user. * * <p>When the chat is connected, a {@link DCCConnectedEvent} will be fired. If the connection fails, * a {@link DCCFailedEvent} will be fired.</p> */

kashike · 2016-09-15T18:01:35Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        IRCDCCChatSnapshot snapshot() {
+            return new IRCDCCChatSnapshot(this);
+        }
+


No empty line at the end of the class.

kashike · 2016-09-15T18:02:03Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+    abstract class IRCDCCExchangeSnapshot extends IRCActorSnapshot implements DCCExchange {
+
+        protected final io.netty.channel.Channel nettyChannel;
+        private final SocketAddress local;


localAddress

kashike · 2016-09-15T18:02:04Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+
+        protected final io.netty.channel.Channel nettyChannel;
+        private final SocketAddress local;
+        private final SocketAddress remote;


remoteAddress

kashike · 2016-09-15T18:02:32Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        @Override
+        @Nonnull
+        public String toString() {
+            return new ToStringer(this).add("client", this.getClient()).add("name", this.getName()).add("localSocket", this.local).add("remoteSocket", this.remote).add("connected", this.connected).toString();


localSocket -> localSocketAddress
remoteSocket -> ``remoteSocketAddress`

kashike · 2016-09-15T18:02:51Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        private final String type;
+        private final String name;
+        private io.netty.channel.Channel nettyChannel;
+        private SocketAddress local;


localAddress

kashike · 2016-09-15T18:02:52Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        private final String name;
+        private io.netty.channel.Channel nettyChannel;
+        private SocketAddress local;
+        private SocketAddress remote;


remoteAddress

kashike · 2016-09-15T18:12:03Z

src/main/java/org/kitteh/irc/client/library/Client.java

@@ -829,4 +829,6 @@ default void sendMultiLineNotice(@Nonnull MessageReceiver target, @Nonnull Strin
     * @param reason quit message to send
     */
    void shutdown(@Nonnull String reason);
+
+    void beginDCCChat(@Nonnull User target);


Missing javadocs.

kashike · 2016-09-15T18:12:48Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+public interface DCCExchange extends Actor {
+    /**
+     * Gets the socket address of the local end.
+     * May return null if not connected.


Optional<SocketAddress>

kashike · 2016-09-15T18:12:49Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+
+    /**
+     * Gets the socket address of the remote end.
+     * May return null if not connected.


Optional<SocketAddress>

kashike · 2016-09-15T18:14:27Z

src/main/java/org/kitteh/irc/client/library/event/user/DCCFailedEvent.java

+
+    public DCCFailedEvent(Client client, String reason, Throwable cause) {
+        super(client);
+        this.reason = reason;


Should be Sanity checked, or marked as Optional.

kashike · 2016-09-15T18:14:29Z

src/main/java/org/kitteh/irc/client/library/event/user/DCCFailedEvent.java

+    public DCCFailedEvent(Client client, String reason, Throwable cause) {
+        super(client);
+        this.reason = reason;
+        this.cause = cause;


Should be Sanity checked, or marked as Optional.

kashike · 2016-09-15T18:14:58Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        abstract void onMessage(String msg);
+
+        final void onSocketBound() {
+            sendCTCP();


kashike · 2016-09-15T18:15:50Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+
+        @Override
+        public void sendMessage(@Nonnull String message) {
+            Sanity.nullCheck(message, "message cannot be null");


Should most likely ensure the contents of the message are valid? Not sure if DCC allows different content and does not need validation.

DCC only limitation is that messages are CRLF terminated. I think that accepting CRLF in the message is fine.

kashike · 2016-09-15T18:16:09Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

 import java.util.Queue;
 import java.util.Set;
 import java.util.concurrent.ConcurrentLinkedQueue;
 import java.util.concurrent.TimeUnit;

 final class NettyManager {
+


No new line at start of class.

kashike · 2016-09-15T18:25:01Z

src/main/java/org/kitteh/irc/client/library/element/User.java

@@ -108,6 +109,7 @@
     *
     * <p>When the chat is connected, a {@link DCCConnectedEvent} will be fired. If the connection fails,
     * a {@link DCCFailedEvent} will be fired.</p>
+     * @see Client#beginDCCChat(User)


New line before this.

Zarthus · 2016-09-15T18:32:11Z

src/main/java/org/kitteh/irc/client/library/Client.java

@@ -829,4 +831,12 @@ default void sendMultiLineNotice(@Nonnull MessageReceiver target, @Nonnull Strin
     * @param reason quit message to send
     */
    void shutdown(@Nonnull String reason);
+
+    /**


I think this comment is really well written.

kashike · 2016-09-15T18:38:57Z

src/main/java/org/kitteh/irc/client/library/element/DCCChat.java

+
+import javax.annotation.Nonnull;
+
+public interface DCCChat extends DCCExchange {


How does one "shutdown"/"terminate" a DCC chat?

you don't

jk it's coming.

see close in DCCExchange

dequis · 2016-09-15T18:59:43Z

dequis was assigned by mbax

Hold on am i a contributor here or did github extend assignments to non-contributors too? Either way whoa.

kashike · 2016-09-15T19:00:50Z

You're a ~~mean one~~ collaborator, Mr. @dequis.

lol768 · 2016-09-15T19:05:36Z

Any plans for increasing the (💥 🌠 ☑️ 🎉 ) coverage once the work is stable? Seems it would currently be decreased by pulling.

Lemme know if you want a hand with testing

Zarthus · 2016-09-15T19:31:19Z

src/main/java/org/kitteh/irc/client/library/element/User.java

+     *
+     * @see Client#beginDCCChat(User)
+     */
+    default void beginDCCChat() {


I'd consider renaming this to requestDccChat over begin, because the latter sort-of implies that the target-user does not have to confirm it. In this case you're requesting a (connection|chat), not beginning it. Might be useful to have some more opinions on this. Afaik DCC only sends your IP if you accept, right?

(Unless they don't, and I'm just wrong.)

You're right, it is a request.

The protocol goes like this:

A = Initiator B = Target A: "/ctcp DCC CHAT chat <bound-ip> <bound-port>" B: Accept/rejects, on accept connects to <bound-ip>:<bound-port> A/B: Send CRLF terminated messages.

octylFractal · 2016-09-15T19:41:59Z

@lol768 test will be coming as soon as this lands out of WIP 📝

octylFractal · 2016-09-15T19:48:01Z

src/main/java/org/kitteh/irc/client/library/implementation/EventListener.java

+                        case "DCC":
+                            // Handle targeted DCC chat
+                            // this.fire(new DCCRequestEvent());
+                            // TODO how can the parameters be extracted @mbaxter???


event.getParameters().get(2) is going to be the CHAT
3 will be ... uh... chat again? wut
4 will be ip
5 will be ... addr? What is your documentation saying? :P

mbax · 2016-09-16T00:06:40Z

src/main/java/org/kitteh/irc/client/library/Client.java

+    /**
+     * Sends a DCC CHAT request to the target.
+     *
+     * <p>When the chat is connected, a {@link DCCConnectedEvent} will be fired. If the connection fails,


I wrap javadocs at a max of column 78.

Also, I don't use html tags for this. Seems to work out fine. :3

it won't actually work out fine, at least in Eclipse

Only thing that I care about for 'fine' is the resulting javadocs page.

mbax

Fun stuff. Some initial comments made.

mbax · 2016-09-16T00:08:45Z

src/main/java/org/kitteh/irc/client/library/element/DCCChat.java

+    /**
+     * Sends the user a message over DCC chat.
+     *
+     * <p>This method won't return until the chat is connected and the message has


Why is this blocking, though? What if you want to send multiple messages over one DCC session?

If we decide to stick with blocking, I'd advocate for the word 'block' or 'blocking' in the javadoc.

It's actually non-blocking currently, I need to update docs.

But I don't understand how blocking affects sending multiple messages?

It affects it only in terms of causing some very sloooooow code. :3

I'm trying to keep KICL non-blocking everywhere I can in the API.

mbax · 2016-09-16T00:09:51Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+public interface DCCExchange extends Actor {
+    /**
+     * Gets the socket address of the local end.
+     * May return {@link Optional#empty()} if not connected.


I'd just leave it as @return the socket address of the local end if connected

Same for the one below

mbax · 2016-09-16T00:10:18Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+    /**
+     * Gets the connection status.
+     *
+     * @return {@code true} if the exchange is connected, otherwise false


I should probably update my stuff to be {@code true} but why do you not do it for false?

mbax · 2016-09-16T00:10:55Z

src/main/java/org/kitteh/irc/client/library/element/User.java

+    default void requestDCCChat() {
+        this.getClient().requestDCCChat(this);
+    }
+


No line here thx

mbax · 2016-09-16T00:16:00Z

src/main/java/org/kitteh/irc/client/library/implementation/EventListener.java

+                        case "DCC":
+                            // Handle targeted DCC chat
+                            // this.fire(new DCCRequestEvent());
+                            // TODO how can the parameters be extracted @mbaxter???


event.getParameters().get(2) is going to be the CHAT
3 will be ... uh... chat again? wut
4 will be ip
5 will be ... addr? What is your documentation saying? :P

mbax · 2016-09-16T00:17:25Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

+        private final IRCDCCExchange exchange;
+        private final InternalClient client;
+        // Only allow one connection per DCC. Weird, I know.
+        private boolean oneConnection;


Perhaps rename to connected? Or something similar. if(oneConnection) reads oddly to me.

it's happened

mbax · 2016-09-16T00:18:28Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

+            }
+            this.oneConnection = true;
+            this.exchange.setNettyChannel(channel);
+            dccConnections.computeIfAbsent(this.client, c -> new ArrayList<>()).add(channel);


Reference this a bit more... clearly. NettyManager.this.dccConnections

It's actually NettyManager.dccConnections. Do you still want fully qualified for outer static fields?

done and done

mbax · 2016-09-16T00:19:25Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java


    private NettyManager() {

    }

    private static synchronized void removeClientConnection(@Nonnull ClientConnection connection, boolean reconnecting) {
        connections.remove(connection);
+        List<Channel> dcc = dccConnections.get(connection.client);


this.dccConnections

NettyManager.dccConnections?

Uhhhhh yeah. Missed it being static. This is fine.

kashike · 2016-09-16T05:47:52Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

@@ -333,6 +446,28 @@ public void initChannel(SocketChannel channel) throws Exception {
        return clientConnection;
    }

+    static Runnable connectDCC(InternalClient client, IRCDCCExchange exchange) {
+        Sanity.nullCheck(eventLoopGroup, "A DCC connection cannot be made without a client");
+        ServerBootstrap dccBootstrap = new ServerBootstrap();


You can chain this all:

ChannelFuture future = new ServerBootstrap() .channel(NioServerSocketChannel.class); .childHandler(new DCCConnection(exchange, client)); .childOption(ChannelOption.TCP_NODELAY, true) .childOption(ChannelOption.SO_KEEPALIVE, true) .group(eventLoopGroup) .bind(0);

diddly dang done

kashike · 2016-09-16T05:49:37Z

src/main/java/org/kitteh/irc/client/library/implementation/NettyManager.java

+            dccConnections.computeIfAbsent(this.client, c -> new ArrayList<>()).add(channel);
+
+            // Outbound - Processed in pipeline back to front.
+            channel.pipeline().addFirst("[OUTPUT] Output listener", new MessageToMessageEncoder<String>() {


This looks like lots of duplication from above - it should be possible to share most, if not all, of it.

kashike · 2016-09-16T05:51:49Z

src/main/java/org/kitteh/irc/client/library/Client.java

+     * a {@link DCCConnectedEvent} will be fired. If the connection fails, a
+     * {@link DCCFailedEvent} will be fired.</p>
+     */
+    void requestDCCChat(@Nonnull User target);


So there's a way to request a new DCC chat, but I see no way to get existing ones.

I don't know if that should be needed? All DCC chats will come through as events so you can keep tabs on them if you want.

However, it currently isn't possible to tell if you have multiple DCC exchanges open to a client or distinguish between them, so maybe we can figure out a way to do that and add a way to get a specific event?

kashike · 2016-09-16T05:52:31Z

src/main/java/org/kitteh/irc/client/library/element/DCCExchange.java

+/**
+ * Represents an exchange using DCC.
+ */
+public interface DCCExchange extends Actor {


extends Actor, Closeable?

checked and done

kashike · 2016-10-21T09:20:35Z

src/main/java/org/kitteh/irc/client/library/implementation/EventListener.java

@@ -977,6 +978,9 @@ public void ctcp(ClientReceiveCommandEvent event) {
                        case "FINGER":
                            reply = "FINGER om nom nom tasty finger";
                            break;
+                        case "DCC":
+                            handleDccEvent(user, event.getOriginalMessages(), event.getParameters());


kashike · 2016-10-21T09:20:51Z

src/main/java/org/kitteh/irc/client/library/implementation/EventListener.java

+            } catch (NumberFormatException invalidPort) {
+                return;
+            }
+            fire(new DCCRequestEvent(this.client, originalMessages, dccType, ip, portInt, user));


kashike · 2016-10-21T09:22:52Z

src/main/java/org/kitteh/irc/client/library/event/user/DCCFailedEvent.java

+     * @return the readable reason for the failure
+     */
+    public Optional<String> getReason() {
+        return Optional.ofNullable(this.reason);


Store the Optional in the field instead.

kashike · 2016-10-21T09:22:59Z

src/main/java/org/kitteh/irc/client/library/event/user/DCCFailedEvent.java

+     * @return the exception that caused the failure
+     */
+    public Optional<Throwable> getCause() {
+        return Optional.ofNullable(this.cause);


Store the Optional in the field instead.

kashike · 2016-10-21T09:23:20Z

src/main/java/org/kitteh/irc/client/library/event/user/DCCRequestEvent.java

+        this.port = port;
+    }
+
+    public String getType() {


kashike · 2016-10-21T09:27:51Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+            ActorProvider.this.client.sendCTCPMessage(this.getName(), this.getCTCP());
+        }
+
+        String getType() {


kashike · 2016-10-21T09:28:07Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+            ActorProvider.this.client.getEventManager().callEvent(new DCCMessageEvent(ActorProvider.this.client, Collections.emptyList(), snapshot(), msg));
+        }
+
+        @Override


kashike · 2016-10-21T09:28:12Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+        }
+
+        @Override
+        IRCDCCChatSnapshot snapshot() {


kashike · 2016-10-21T09:28:23Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+            this.connected = actor.connected;
+        }
+
+        @Override


kashike · 2016-10-21T09:28:25Z

src/main/java/org/kitteh/irc/client/library/implementation/ActorProvider.java

+            return Optional.ofNullable(this.localAddress);
+        }
+
+        @Override


mbax · 2017-01-03T23:53:16Z

k then

octylFractal · 2017-01-03T23:58:07Z

💀 RIP DCC....

attempt 1.

DCC 2: Electric Boogaloo

Coming soon to a repository near you.

Zarthus reviewed Sep 15, 2016

View reviewed changes

kashike suggested changes Sep 15, 2016

View reviewed changes

kashike reviewed Sep 15, 2016

View reviewed changes

Zarthus approved these changes Sep 15, 2016

View reviewed changes

kashike reviewed Sep 15, 2016

View reviewed changes

mbax added enhancement DCC IS TERRIBLE [MINOR] new API / feature work in progress labels Sep 15, 2016

mbax added this to the Future! milestone Sep 15, 2016

mbax assigned dequis Sep 15, 2016

Zarthus reviewed Sep 15, 2016

View reviewed changes

octylFractal commented Sep 15, 2016

View reviewed changes

mbax reviewed Sep 16, 2016

View reviewed changes

octylFractal force-pushed the feature/dcc branch from 40c6bb6 to 1f642f9 Compare September 16, 2016 04:10

kashike suggested changes Sep 16, 2016

View reviewed changes

kashike suggested changes Oct 21, 2016

View reviewed changes

octylFractal closed this Jan 3, 2017

octylFractal force-pushed the feature/dcc branch from ad9896f to 5060a91 Compare January 3, 2017 23:35

octylFractal mentioned this pull request Jan 4, 2017

DCC 2: Electric Boogaloo #172

Closed

7 tasks

mbax modified the milestone: Future! Apr 27, 2017

		import javax.annotation.Nonnull;

		public interface DCCChat extends DCCExchange {

		}

		class IRCDCCChatSnapshot extends IRCDCCExchangeSnapshot implements DCCChat {

[WIP] DCC Chat/Send #138

[WIP] DCC Chat/Send #138

Conversation

octylFractal commented Sep 15, 2016 • edited Loading

codecov-io commented Sep 15, 2016 • edited Loading

Current coverage is 32.46% (diff: 0.00%)

Zarthus commented Sep 15, 2016

octylFractal commented Sep 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octylFractal Sep 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kashike left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kashike Sep 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kashike Sep 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dequis commented Sep 15, 2016

kashike commented Sep 15, 2016

lol768 commented Sep 15, 2016

Zarthus Sep 15, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octylFractal commented Sep 15, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbax left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbax Sep 16, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

octylFractal commented Sep 15, 2016 •

edited

Loading

codecov-io commented Sep 15, 2016 •

edited

Loading

octylFractal Sep 15, 2016 •

edited

Loading

kashike Sep 15, 2016 •

edited

Loading

kashike Sep 15, 2016 •

edited

Loading

Zarthus Sep 15, 2016 •

edited

Loading

mbax Sep 16, 2016 •

edited

Loading

octylFractal Sep 16, 2016 •

edited

Loading