Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I'm the master of disguise #207

Closed
wants to merge 15 commits into from

Conversation

kashike
Copy link
Member

@kashike kashike commented Oct 8, 2017

Adds #130.
Supersedes #158.

@codecov-io
Copy link

codecov-io commented Oct 8, 2017

Codecov Report

Merging #207 into next will increase coverage by 0.02%.
The diff coverage is 31.78%.

Impacted file tree graph

@@             Coverage Diff              @@
##               next     #207      +/-   ##
============================================
+ Coverage     32.29%   32.32%   +0.02%     
- Complexity      501      529      +28     
============================================
  Files           211      220       +9     
  Lines          4214     4353     +139     
  Branches        448      460      +12     
============================================
+ Hits           1361     1407      +46     
- Misses         2797     2887      +90     
- Partials         56       59       +3
Impacted Files Coverage Δ Complexity Δ
...ain/java/org/kitteh/irc/client/library/Client.java 9.37% <ø> (ø) 1 <0> (ø) ⬇️
...h/irc/client/library/implementation/IrcClient.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...client/library/util/mask/operation/NegateMask.java 0% <0%> (ø) 0 <0> (?)
...teh/irc/client/library/util/mask/MaskProvider.java 0% <0%> (ø) 0 <0> (?)
...c/client/library/implementation/ClientBuilder.java 3.66% <0%> (-0.07%) 1 <0> (ø)
...org/kitteh/irc/client/library/element/Channel.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...c/client/library/implementation/EventListener.java 11.74% <0%> (-0.09%) 19 <0> (ø)
...irc/client/library/util/mask/operation/OrMask.java 0% <0%> (ø) 0 <0> (?)
...rc/client/library/util/mask/operation/AndMask.java 0% <0%> (ø) 0 <0> (?)
...ent/library/util/mask/operation/PredicateMask.java 0% <0%> (ø) 0 <0> (?)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bf9d9d...cd26e6b. Read the comment docs.

@kashike kashike force-pushed the feature/master-of-disguise branch 2 times, most recently from 2de47ff to 5cdd105 Compare October 8, 2017 20:08
new TestUser("mbaxter", "~mbax", "kitten.institute", null),
new TestUser("kashike", "kashike", "kitten.institute", null)
), Collections.singletonList(
new TestUser("lol768", "lol768", "andy.in.toy.story", null)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😐

@kashike kashike force-pushed the feature/master-of-disguise branch from 17b660c to a61d21a Compare December 11, 2017 01:31
@kashike kashike force-pushed the feature/master-of-disguise branch from 4b5410c to a1626b7 Compare December 11, 2017 02:49
@bendem
Copy link

bendem commented Dec 11, 2017

I'm not quite sure why you added Mask.AsString extends Mask since you're only using AsString. I'd move that method to Mask and use that instead. I can't think of a mask that's not representable as a string anyway

@bendem
Copy link

bendem commented Dec 11, 2017

Partial wildcards are not supported either. A HostMask with host = 192.168.* will not work.

@mbax mbax mentioned this pull request Feb 19, 2019
13 tasks
@mbax
Copy link
Member

mbax commented Feb 19, 2019

#130 (comment)

@mbax mbax closed this Feb 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants