fix: Safe Guard Feature List #4
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
claas-c
approved these changes
Sep 26, 2024
AshishBhattarai
force-pushed
the
master
branch
from
0dc3ab7 to
deea312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Proposed fix to ensure that feature list is checked as we have had a scenario where the
featureListcan set tonull.Root cause unknown for a specific custom font that had
this.languagebut nothis.table.featureListset tonull.This PR includes:
Might be worth doing further investigation to ensure this can not be handled further up the stack. Leaving as draft PR for now.