Types on test settings #5643
Types on test settings #5643
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Signed-off-by: Jess Frazelle <[email protected]>
Signed-off-by: Jess Frazelle <[email protected]>
jessfraz
force-pushed
the
types-on-test-settings
branch
from
4d545ee to
53be9bf
Compare
Signed-off-by: Jess Frazelle <[email protected]>
jessfraz
force-pushed
the
types-on-test-settings
branch
from
978b08e to
c834898
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5643 +/- ##
==========================================
+ Coverage 85.67% 85.69% +0.01%
==========================================
Files 106 106
Lines 41209 41209
==========================================
+ Hits 35304 35312 +8
+ Misses 5905 5897 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Looks like real test failure? Settings related |
Signed-off-by: Jess Frazelle <[email protected]>
|
@lf94 yeah just fixed :) made it even more type proof haha |
Signed-off-by: Jess Frazelle <[email protected]>
| @@ -85,7 +86,7 @@ export class AuthenticatedTronApp { | |||
| fixtures: Partial<Fixtures> | |||
| folderSetupFn?: (projectDirName: string) => Promise<void> | |||
| cleanProjectDir?: boolean | |||
| appSettings?: Partial<SaveSettingsPayload> | |||
| appSettings?: DeepPartial<Settings> | |||
There was a problem hiding this comment.
Oh my god this is SO MUCH NICER
| @@ -12,9 +12,10 @@ import { CmdBarFixture } from './cmdBarFixture' | |||
| import { EditorFixture } from './editorFixture' | |||
| import { ToolbarFixture } from './toolbarFixture' | |||
| import { SceneFixture } from './sceneFixture' | |||
| import { SaveSettingsPayload } from 'lib/settings/settingsTypes' | |||
| @@ -22,7 +26,7 @@ test.describe('Onboarding tests', () => { | |||
| { | |||
| appSettings: { | |||
| app: { | |||
| onboardingStatus: '', | |||
| onboarding_status: '', | |||
There was a problem hiding this comment.
Oh, isn't it weird this isnt camelCase?...
part of #5625
this helps with #4919 migration as well