feat(objwriter): add support for vtkOBJWriter #2405
Conversation
daker
force-pushed
the
add-objwriter
branch
2 times, most recently
from
68353a6 to
175a919
Compare
| /** | ||
| * vtkOBJWriter writes wavefront obj (.obj) files in ASCII form. OBJ files | ||
| * contain the geometry including lines, triangles and polygons. Normals and | ||
| * texture coordinates on points are also written if they exist. |
There was a problem hiding this comment.
you might want to mention that materials are not written out.
There was a problem hiding this comment.
I have written the code for the mlt part, but i don't know how it can be exposed? user need to pass the vtkTexture? or just pass the texture filename?
@jourdain do you have any idea how to expose the texture export?
There was a problem hiding this comment.
yes, a vtkTexture (or vtkImageData?) would need to be optionnally passed (i.e. as a second input macro.algo(publicAPI, model, 2, 1);)
I guess it could output the mtl part in a second output (i.e. macro.algo(publicAPI, model, 1, 2); and outData[1] = ... )
There was a problem hiding this comment.
ok i will re-add the mtl code again
There was a problem hiding this comment.
i am trying to finish this PR, by calling the getOutputData(1) i am getting an error
Uncaught TypeError: model.output[count].isDeleted is not a function
at publicAPI.shouldUpdate (macros.js:853:55)
at Object.getOutputData (macros.js:839:19)in both outputs i am returning strings
const objContent = writer.getOutputData(0);
const mtlContent = writer.getOutputData(1);Displaying the content of model.output[count], i can see it's returned string hence the error, so i am not sure if it's a bug or not.
There was a problem hiding this comment.
Did you check vtkMoleculeToRepresentation that produces 2 outputs ?
There was a problem hiding this comment.
Yes but it does produce two polydatas that's why it works, here i am producing two strings to be returned
There was a problem hiding this comment.
I see, I think I got confused at some point. A writer is not really meant to have any output.
getOutputData() is supposed to create a vtkDataSet, in your case getOutput() should be enough.
There was a problem hiding this comment.
i don't think getOutput() exist in vtk.js
There was a problem hiding this comment.
Indeed, it's a VTK thing, not VTK.js. My bad. Then I guess you should not have those strings as outputs. Maybe that writer should not have any output at the end of the day finally. A simple get accessor could replace those...
|
|
||
| global.writer = writer; | ||
| global.writerReader = writerReader; | ||
| global.fullScreenRenderer = fullScreenRenderer; |
There was a problem hiding this comment.
can you demonstrate how to write the obj, mtl and texture ?
fix #2404
Context
Add support for vtkOBJWriter
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting