fix(index.d.ts): fix getPixelWorldHeightAtCoord missing parameter#3236
Merged
finetjul merged 1 commit intoKitware:masterfrom Mar 28, 2025
Merged
fix(index.d.ts): fix getPixelWorldHeightAtCoord missing parameter#3236finetjul merged 1 commit intoKitware:masterfrom
finetjul merged 1 commit intoKitware:masterfrom
Conversation
finetjul
requested changes
Mar 27, 2025
Member
finetjul
left a comment
There was a problem hiding this comment.
Please squash your commits and follow https://www.conventionalcommits.org/ style (i.e. use npm run commit)
finetjul
reviewed
Mar 28, 2025
Member
I think it is correct. |
|
🎉 This PR is included in version 32.12.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, the
getPixelWorldHeightAtCoordfunction inSources/Widgets/Core/WidgetManager/index.jshas a second parameter in its implementation, but the corresponding TypeScript definition inSources/Widgets/Core/WidgetManager/index.d.tsis missing this parameter. This discrepancy may lead to type errors for TypeScript users.Relevant code locations:
Results
This change updates the TypeScript definition to align with the implementation, preventing type errors when using
getPixelWorldHeightAtCoord.Before Change
After Change
Changes
index.d.tsto include the missing second parameter.PR and Code Checklist
npm run reformatto ensure proper code formatting.Testing