Fix improper file copy and improve "import local build" window #319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problems ive been encountering on linux by using the import local build function where build files where copied to an incorrect folder.
Additionally:
I reworked the look of the window a bit, added expanders and auto close on finish.
Changed the open file / open folder dialogs to use this window as the base rather than the mainwindow, this avoids the posibility of the dialog to be open hidden behind the import local build window.
This same method needs to be applied to other dialogs where a file open or folder open dialog is involved, but will be done on a separated PR.
As for the file copy fix, it mostly involves removing the specific folder copy method used here and instead adapt the one on KnUtils to be usable for this task.