Replace `bool` with `false` at `Adapter` methods that return `false` on failure #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draft

phansys wants to merge 1 commit into KnpLabs:master from phansys:bool_on_failure

phansys commented Dec 14, 2023

This way, we make explicit the behavior and avoid the false expectation of returning true on success.


          Replace bool with false at Adapter methods that return false …

b1a00a7

…on failure

PedroTroller self-assigned this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet