move translator requirement to dev #838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR moves the symfony/translation dependency from the production requirements to development requirements in the Composer configuration, addressing issue #837.
- Relocated
symfony/translationfrom therequiresection torequire-devsection - Fixed comma formatting in the
require-devsection to accommodate the moved dependency
Comment on lines
27
to
+34
| "twig/twig": "^3.0" | ||
| }, | ||
| "require-dev": { | ||
| "phpstan/phpstan": "^1.12", | ||
| "phpunit/phpunit": "^10.5 || ^11.5 || ^12.0", | ||
| "symfony/expression-language": "^6.4 || ^7.0", | ||
| "symfony/templating": "^6.4 || ^7.0" | ||
| "symfony/templating": "^6.4 || ^7.0", | ||
| "symfony/translation": "^6.4 || ^7.0" |
There was a problem hiding this comment.
Moving symfony/translation to require-dev suggests it's only needed for development/testing. Verify that no production code depends on translation services, as this change could break functionality if translation features are used in the main application code.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #837