Skip to content

Fixes Issue 25: Implement goal-based and rotational group types #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Queenode merged 6 commits into from
Jul 21, 2026
Merged

Fixes Issue 25: Implement goal-based and rotational group types #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
0b720b9
chore: bump soroban-sdk to 27.0.0
Ultra-Tech-code Jul 19, 2026
c85f6a3
feat: implement GoalBased and Rotational group types
Ultra-Tech-code Jul 19, 2026
d165dde
test: add tests for GoalBased group types
Ultra-Tech-code Jul 19, 2026
af23dc3
fix: update test_events assertion to pass in newer SDK
Ultra-Tech-code Jul 19, 2026
a19eeee
chore: track Cargo.lock and test snapshots to fix CI build
Ultra-Tech-code Jul 20, 2026
ba59604
ci: use wasm32v1-none target for Soroban SDK 27.0.0 and Rust 1.84+
Ultra-Tech-code Jul 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/rust.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ jobs:
run: |
rustup toolchain install stable --profile minimal
rustup default stable
rustup target add wasm32-unknown-unknown
rustup target add wasm32v1-none

@coderabbitai coderabbitai Bot Jul 20, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🩺 Stability & Availability | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

rg -n 'wasm32(-unknown-unknown|v1-none)|wasm32v1-none' \
  --glob '*.yml' --glob '*.yaml' --glob '*.sh' --glob 'README*' --glob 'Cargo.toml'

Repository: Kolo-Org/Kolo-smartcontract

Length of output: 165

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Files:\n'
git ls-files | rg '(^|/)(rust\.yml|ci\.yml|deploy\.sh|README\.md|Cargo\.toml)$|github_actions/workflows'
printf '\nTarget references:\n'
rg -n 'wasm32(-unknown-unknown|v1-none)|wasm32v1-none' \
  .github github_actions contracts README.md Cargo.toml \
  --glob '*.yml' --glob '*.yaml' --glob '*.sh' --glob 'README*' --glob 'Cargo.toml' || true

Repository: Kolo-Org/Kolo-smartcontract

Length of output: 2549

🏁 Script executed:

#!/bin/bash
set -euo pipefail

printf 'Workflow files:\n'
git ls-files '.github/workflows/*' 'github_actions/workflows/*' | sort

printf '\nPotential deployment files:\n'
git ls-files | rg 'deploy\.sh|README\.md|Cargo\.toml|ci\.yml$' | sort

printf '\nRust workflow excerpt:\n'
nl -ba .github/workflows/rust.yml | sed -n '1,120p'

Repository: Kolo-Org/Kolo-smartcontract

Length of output: 724

Keep the WASM target consistent across the repo. This workflow now uses wasm32v1-none, but contracts/deploy.sh, README.md, and github_actions/workflows/ci.yml still reference wasm32-unknown-unknown, so CI/docs/deploy will point at different artifact paths. Update the other target references together with this change.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/rust.yml at line 23, Update all WASM target references to
remain consistent with the target used by the workflow’s rustup target
installation: change the references in contracts/deploy.sh, README.md, and
github_actions/workflows/ci.yml from wasm32-unknown-unknown to wasm32v1-none,
including any related artifact paths.


- name: Install system dependencies for Soroban CLI
run: |
Expand All @@ -34,4 +34,4 @@ jobs:
run: cargo test

- name: Build contract for wasm (release)
run: cargo build --target wasm32-unknown-unknown --release
run: cargo build --target wasm32v1-none --release
1 change: 0 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ scripts/e2e-artifacts/*
# Rust / Cargo
target/
**/*.rs.bk
Cargo.lock

# Node.js
node_modules/
Expand Down
Loading
Loading