Activation task deduplication and SharedActivationCoordinator enhancements#5
Activation task deduplication and SharedActivationCoordinator enhancements#5CharlVS wants to merge 3 commits intoKomodo-Community:devfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| scheduleMicrotask(() { | ||
| for (final asset in assets) { | ||
| coordinator | ||
| .activateAssetStream(asset) | ||
| .listen(controller.add, onError: controller.addError); |
There was a problem hiding this comment.
Close activation stream controller so callers can complete
When SharedActivationCoordinator is available, activateAssets now creates a broadcast controller and forwards each asset’s activation stream, but the controller is never closed or completed once the forwarded streams finish. As a result the returned stream never emits done, so any caller awaiting completion (e.g. await activateAssets([...]).last) will hang indefinitely and the controller/listeners stay live even after all activations end. The old implementation from ActivationManager.activateAssets completed normally, so this is a regression.
Useful? React with 👍 / 👎.
Copied from upstream PR GLEECBTC#274
closes GLEECBTC#273
Summary
AssetIdacross the SDK by routing all public activation calls throughSharedActivationCoordinatorand makingActivationManageridempotent at init.Acceptance criteria