-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Custom Token Import UI and BLoC #2515
Conversation
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Visit the preview URL for this PR (updated for commit e7f51dd): https://walletrc--pull-2515-merge-byr1n75e.web.app (expires Thu, 20 Feb 2025 18:43:19 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc |
689882b
to
493833d
Compare
ease transition to SDK by allowing supporting code to transition to using AssetId rather than Coin or coin ticker / abbreviation
fixes non-responsive UI due to immutable MainLayout ignoring routing and layout size changes
the use of `.single` in `getSdkAsset` would result in exceptions for coins that were not in the known assets list
add the token icon url to the protocol metadata for extraction from the SDK on refresh
30dda13
to
1f6e74c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work. Please resolve the merge conflicts from the recently merged PR #2527.
As usual, please enable trailing commas, run dart fix --apply . && dart format .
, and then commit changes to files/code modified in the PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@takenagain Please also add the token contract addresses used for testing to the PR description. |
I removed the dead space in 94d6be5 along with a fix to enable the network asset before fetching custom token info in e7f51dd. I used the simple approach of adjusting the existing widget height properties, as there is still something requesting full vertical height in the dialog when removing the height property in the |
Continuation of #176 by @naezith.
Modifications made since the original PR
custom_token_import_integration.mov
Some unlisted coins used for testing