Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Custom Token Import UI and BLoC #2515

Merged
merged 58 commits into from
Feb 16, 2025
Merged

Conversation

takenagain
Copy link
Collaborator

@takenagain takenagain commented Jan 27, 2025

Continuation of #176 by @naezith.

Modifications made since the original PR

  • Migrated RPC functions to SDK (#22)
  • Used SDK metadata storage to store custom tokens (#22)
custom_token_import_integration.mov

Some unlisted coins used for testing

  • GOON - (Polygon): 0x433cDE5a82b5e0658dA3543b47A375dffd126Eb6
  • PNIC (Avalanche): 0x4f3c5C53279536fFcfe8bCafb78E612E933D53c6
  • SHIFU (ERC20): 0x2CC7A972ebC1865B346085655f929AbFa74CD4dC
  • Everclear (ERC20): 0x58b9cB810A68a7f3e1E4f8Cb45D1B9B3c79705E8
  • SYLVESTER (ERC20): 0xE0337B8835D9887e8B1294CEcBbDBcff7b299f41
  • Hoodrat (ERC20): 0x62B6d83d5aFBf395ece55136E7161c119a8FD80C
  • fWTIOIL (Fantom - no coingecko icon): 0xe297e06761a5489380538a0308b6f9b4a53bea45
  • TemplarDAO (Moonriver): 0xD86E3F7B2Ff4e803f90c799D702955003bcA9875

@takenagain takenagain self-assigned this Jan 27, 2025
Copy link

coderabbitai bot commented Jan 27, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Jan 27, 2025

Visit the preview URL for this PR (updated for commit e7f51dd):

https://walletrc--pull-2515-merge-byr1n75e.web.app

(expires Thu, 20 Feb 2025 18:43:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@takenagain takenagain force-pushed the feature/custom-token-import branch from 689882b to 493833d Compare January 27, 2025 16:23
ease transition to SDK by allowing supporting code to transition to using AssetId rather than Coin or coin ticker / abbreviation
fixes non-responsive UI due to immutable MainLayout ignoring routing and layout size changes
the use of `.single` in `getSdkAsset` would result in exceptions for coins that were not in the known assets list
add the token icon url to the protocol metadata for extraction from the SDK on refresh
@takenagain takenagain force-pushed the feature/custom-token-import branch from 30dda13 to 1f6e74c Compare February 6, 2025 17:47
@CharlVS CharlVS added enhancement New feature or request new feature labels Feb 10, 2025
@takenagain takenagain requested a review from CharlVS February 12, 2025 21:54
@takenagain takenagain marked this pull request as ready for review February 12, 2025 21:55
Copy link
Member

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work. Please resolve the merge conflicts from the recently merged PR #2527.

As usual, please enable trailing commas, run dart fix --apply . && dart format ., and then commit changes to files/code modified in the PR.

Copy link
Member

@CharlVS CharlVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work. Please change the height of the modal to be flexible based on the contents and eliminate this dead space. I'm assuming that is there because of the initial spec where we were expecting the user to provide the decimal count.

image

@CharlVS
Copy link
Member

CharlVS commented Feb 13, 2025

@takenagain Please also add the token contract addresses used for testing to the PR description.

@takenagain
Copy link
Collaborator Author

Great work. Please change the height of the modal to be flexible based on the contents and eliminate this dead space. I'm assuming that is there because of the initial spec where we were expecting the user to provide the decimal count.

I removed the dead space in 94d6be5 along with a fix to enable the network asset before fetching custom token info in e7f51dd.

I used the simple approach of adjusting the existing widget height properties, as there is still something requesting full vertical height in the dialog when removing the height property in the SizedBox widget.

@CharlVS CharlVS merged commit 538aadf into dev Feb 16, 2025
3 of 7 checks passed
@CharlVS CharlVS deleted the feature/custom-token-import branch February 16, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants