Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(router): frozen layout on navigation and resize #2521

Merged
merged 6 commits into from
Feb 7, 2025
Merged

Conversation

takenagain
Copy link
Collaborator

@takenagain takenagain commented Feb 5, 2025

Changes

  • bump SDK version hash in pubspec.lock (dev branch is using an outdated SDK release)
  • fixes the frozen layout when navigating and resizing
  • fixes blank coin charts on the guest view (CEX asset not found in available coins list)

fixes non-responsive UI due to immutable MainLayout ignoring routing and layout size changes
the use of `.single` in `getSdkAsset` would result in exceptions for coins that were not in the known assets list
@takenagain takenagain self-assigned this Feb 5, 2025
Copy link

coderabbitai bot commented Feb 5, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

github-actions bot commented Feb 5, 2025

Visit the preview URL for this PR (updated for commit 8794b15):

https://walletrc--pull-2521-merge-9w50wxbr.web.app

(expires Fri, 14 Feb 2025 17:43:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f66a4ff03faa546f12f0ae5a841bd9eff2714dcc

@takenagain takenagain marked this pull request as ready for review February 5, 2025 14:51
@takenagain takenagain requested a review from CharlVS February 5, 2025 14:51
Comment on lines 36 to 38
// filter out assets that are not in the known coins list to
// prevent errors when using the SDK with the `.single` property
.where((coin) => sdk.assets.assetsFromTicker(coin.id).length == 1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My intention with using the .single property instead of .first/.firstOrNull was to intentionally throw an exception if there is more than one asset for a given ticker. This was possible before the SLP project was abandoned.

Although unlikely, if the coins repo has a change pushed to it where this assumption no longer holds true, then we want to error out because there are many instances where we've assumed a given ticker will have exactly 1 or 0 coins/assets, which may wreak havoc if it's not treated as a breaking change.

Unless the surrounding context makes it redundant, please change this to:

Suggested change
// filter out assets that are not in the known coins list to
// prevent errors when using the SDK with the `.single` property
.where((coin) => sdk.assets.assetsFromTicker(coin.id).length == 1)
// filter out assets that are not in the known coins list to
// prevent errors when using the SDK with the `.single` property
.where((coin) => sdk.assets.assetsFromTicker(coin.id).length >= 1)

Also, we could add an SDK method for sdk.assets.maybeAssetsFromTicker

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The await cexPriceRepository.getCoinList() function on line 34 above returns a list of coins from Binance, some of which are not in our coins repository / config. Line 38 filters out assets that are not in the “known”/available assets list, or that might have more than one asset for a given ticker.

The entire application crashes in the guest/unauthenticated Wallet page because of the .single call in getSdkAsset throwing an exception in the UI layer (no entries in the set).

I updated the comment to clarify the purpose of the filter in 8ff69c2

Although unlikely anytime soon, if the coins repo has a change pushed to it where this assumption no longer holds true, then we want to error out because there are many instances where we've assumed a given ticker will have exactly 1 or 0 coins/assets, which may wreak havoc if it's not treated as a breaking change.
@CharlVS CharlVS merged commit 869c8fa into dev Feb 7, 2025
2 of 6 checks passed
@CharlVS CharlVS deleted the fix/frozen-layout branch February 7, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants