Create tests in Insomnia #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
cloudjumpercat
commented
Sep 26, 2024
cloudjumpercat
commented
- how to page covering how to create tests in Insomnia
Signed-off-by: Diana <[email protected]>
✅ Deploy Preview for kongdeveloper ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Diana <[email protected]>
…pages to the tests landing page Signed-off-by: Diana <[email protected]>
cloudjumpercat
commented
Sep 30, 2024
Comment on lines
+65
to
+71
| ```javascript | ||
| const response1 = await insomnia.send(); | ||
| const body = JSON.parse(response1.data); | ||
| expect(body).to.have.property('meal_options'); | ||
| expect(body.meal_options).to.be.an('array'); | ||
| expect(body).to.be.an('object'); | ||
| ``` |
There was a problem hiding this comment.
Note for reviewers: This was created with ChatGPT. Although the test passes, I don't fully trust it or understand it. Is meal_options really nested? Is this really testing the right thing?
Also, my gut is telling me that some of these lines might be extraneous/unnecessary.
cloudjumpercat
commented
Sep 30, 2024
Comment on lines
+64
to
+73
| ```javascript | ||
| const response1 = await insomnia.send(); | ||
| const body = JSON.parse(response1.data); | ||
| expect(body).to.be.an('object'); | ||
| expect(body).to.have.property('meal_options'); | ||
| expect(body.meal_options).to.be.an('array'); | ||
| if (body.meal_options.length > 0) { | ||
| expect(body.meal_options[0]).to.be.a('string'); | ||
| } | ||
| ``` |
There was a problem hiding this comment.
Note for reviewers: This was created with ChatGPT. Although the test passes, I don't fully trust it or understand it. Is meal_options really nested? Is this really testing the right thing?
Also, my gut is telling me that some of these lines might be extraneous/unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.