feat(*): use cloudsmith instead of pulp to download packages #701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locao
commented
May 29, 2024
Comment on lines
-76
to
-80
| # Uncomment to build a container using the .deb.tar.gz Kong Gateway package | ||
| # For .deb.tar.gz packages, the SHA is in | ||
| # https://download.konghq.com/gateway-<gateway-major-version>-ubuntu/PULP_MANIFEST | ||
| # ARG KONG_AMD64_SHA="<amd64_sha>" | ||
| # ARG KONG_ARM64_SHA="<arm64_sha>" |
There was a problem hiding this comment.
I removed the mentions to this .deb.tar.gz packages as I could not find them. If the reference is still relevant, please let me know and I will add it back.
There was a problem hiding this comment.
Agreed with this, leaving the comment up and "unresolved" for future reviewers.
brentos
approved these changes
May 30, 2024
curiositycasualty
added a commit
that referenced
this pull request
Jun 14, 2024
(cherry picked from commit 6c5f899)
curiositycasualty
added a commit
that referenced
this pull request
Jun 14, 2024
curiositycasualty
added a commit
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the source of
debandrpmpackages from the old pulp repository to the new cloudsmith repository.The changes affect the
Dockerfiles, the documentation and update script.The Gateway version was also bumped to
3.7.0in the process.closes: #700