Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impart Security's WAF and API security plugin #7672

Merged
merged 21 commits into from
Oct 31, 2024

Conversation

marc-harrison
Copy link
Contributor

Description

Adds Impart Security's plugin to Kong's hub.

@marc-harrison marc-harrison requested a review from a team as a code owner July 23, 2024 20:08
Copy link

netlify bot commented Jul 23, 2024

👷 Deploy request for kongdocs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 3380513

@marc-harrison marc-harrison force-pushed the marc/impart_security_kong branch 2 times, most recently from e881323 to 32430fc Compare July 23, 2024 23:43
@lena-larionova
Copy link
Contributor

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have some minor feedback around formatting + need the icon filename to change.

@lena-larionova
Copy link
Contributor

Please ignore the failing smoke test, it doesn't work on forks

@lena-larionova lena-larionova self-assigned this Jul 25, 2024
@marc-harrison
Copy link
Contributor Author

@lena-larionova I think this should be ready. The Broken Links seems to be something on netlify's needing to be redeployed. Let me know if there's anything else. Thanks!

@lena-larionova
Copy link
Contributor

lena-larionova commented Jul 30, 2024

Looks good to me! I reran the broken link check and it used the right deploy this time, so it's good now.

Holding off on publishing until we get the green light from our end.

Copy link
Contributor

@lena-larionova lena-larionova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marc-harrison We've received the go-ahead to publish this.
Do you want to add 3.8 compatibility as well?

@marc-harrison
Copy link
Contributor Author

@lena-larionova added. Thanks!

@lena-larionova lena-larionova merged commit b9f62dd into Kong:main Oct 31, 2024
10 of 11 checks passed
@marc-harrison marc-harrison deleted the marc/impart_security_kong branch November 1, 2024 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants