-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impart Security's WAF and API security plugin #7672
Impart Security's WAF and API security plugin #7672
Conversation
👷 Deploy request for kongdocs pending review.Visit the deploys page to approve it
|
app/_hub/impart-security/kong-plugin-impart/_metadata/_index.yml
Outdated
Show resolved
Hide resolved
e881323
to
32430fc
Compare
app/_hub/impart-security/kong-plugin-impart/_metadata/_index.yml
Outdated
Show resolved
Hide resolved
Preview link works now: https://deploy-preview-7672--kongdocs.netlify.app/hub/impart-security/kong-plugin-impart/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just have some minor feedback around formatting + need the icon filename to change.
Please ignore the failing smoke test, it doesn't work on forks |
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
Co-authored-by: lena-larionova <[email protected]>
ae73632
to
da4e58e
Compare
@lena-larionova I think this should be ready. The Broken Links seems to be something on netlify's needing to be redeployed. Let me know if there's anything else. Thanks! |
Looks good to me! I reran the broken link check and it used the right deploy this time, so it's good now. Holding off on publishing until we get the green light from our end. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marc-harrison We've received the go-ahead to publish this.
Do you want to add 3.8 compatibility as well?
@lena-larionova added. Thanks! |
Description
Adds Impart Security's plugin to Kong's hub.