-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug-bash: Change phase to directive in custom logic doc #8001
Conversation
✅ Deploy Preview for kongdocs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is missing the second part of the issue as well, which is:
An other issue concerns the "reponse" function, for which the phase is "access". However, according to the description, it replaces "header_filter()" and "body_filter()". As shown in the diagram in the Directives section, they are part of "Content Phase", not "Access Phase". This seems to be a mistake.
Edit: After doing more digging, I found that the response
function runs in the Kong response
phase, as a whole separate thing: https://github.com/Kong/kong/blob/master/spec/fixtures/custom_plugins/kong/plugins/enable-buffering-response/handler.lua. The links to the directives are correct though (header_filter and body_filter).
See all the Kong phases here: https://github.com/Kong/kong/blob/master/kong/pdk/private/phases.lua
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tl;dr for the changes I made to this PR:
- marked ws phases as enterprise only
- added a directives column and renamed the original phases column to "Kong phases", which are not the same thing as the nginx phases
- checked each function against its real phase in Kong; the only one that actually differs from its function name is the
configuration
function
Fixes #7533