chore(oas2kong): cleanup unnecessary pointers to slices

cmd/openapi2kong.go

@@ -35,14 +35,14 @@ func executeOpenapi2Kong(cmd *cobra.Command, _ []string) error {
 		return fmt.Errorf("failed getting cli argument 'uuid-base'; %w", err)
 	}
 
-	var entityTags *[]string
+	var entityTags []string
 	{
 		tags, err := cmd.Flags().GetStringSlice("select-tag")
 		if err != nil {
 			return fmt.Errorf("failed getting cli argument 'select-tag'; %w", err)
 		}
-		entityTags = &tags
-		if len(*entityTags) == 0 {
+		entityTags = tags
+		if len(entityTags) == 0 {
 			entityTags = nil
 		}
 	}

openapi2kong/openapi2kong.go

@@ -22,7 +22,7 @@ const (
 
 // O2KOptions defines the options for an O2K conversion operation
 type O2kOptions struct {
-	Tags          *[]string // Array of tags to mark all generated entities with, taken from 'x-kong-tags' if omitted.
+	Tags          []string  // Array of tags to mark all generated entities with, taken from 'x-kong-tags' if omitted.
 	DocName       string    // Base document name, will be taken from x-kong-name, or info.title (for UUID generation!)
 	UUIDNamespace uuid.UUID // Namespace for UUID generation, defaults to DNS namespace for UUID v5
 }
@@ -60,10 +60,10 @@ func sanitizeRegexCapture(varName string) string {
 // getKongTags returns the provided tags or if nil, then the `x-kong-tags` property,
 // validated to be a string array. If there is no error, then there will always be
 // an array returned for safe access later in the process.
-func getKongTags(doc *openapi3.T, tagsProvided *[]string) ([]string, error) {
+func getKongTags(doc *openapi3.T, tagsProvided []string) ([]string, error) {
 	if tagsProvided != nil {
 		// the provided tags take precedence, return them
-		return *tagsProvided, nil
+		return tagsProvided, nil
 	}
 
 	if doc.ExtensionProps.Extensions == nil || doc.ExtensionProps.Extensions["x-kong-tags"] == nil {

openapi2kong/openapi2kong_test.go

@@ -25,7 +25,7 @@ func Test_Openapi2kong(t *testing.T) {
 			fileNameOut := strings.TrimSuffix(fileNameIn, ".yaml") + ".generated.json"
 			dataIn, _ := os.ReadFile(fixturePath + fileNameIn)
 			dataOut, err := Convert(dataIn, O2kOptions{
-				Tags: &[]string{"OAS3_import", "OAS3file_" + fileNameIn},
+				Tags: []string{"OAS3_import", "OAS3file_" + fileNameIn},
 			})
 			if err != nil {
 				t.Error(fmt.Sprintf("'%s' didn't expect error: %%w", fixturePath+fileNameIn), err)

openapi2kong/validator.go

@@ -32,7 +32,7 @@ func getDefaultParamStyle(givenStyle string, paramType string) string {
 // generateParameterSchema returns the given schema if there is one, a generated
 // schema if it was specified, or nil if there is none.
 // Parameters include path, query, and headers
-func generateParameterSchema(operation *openapi3.Operation) *[]map[string]interface{} {
+func generateParameterSchema(operation *openapi3.Operation) []map[string]interface{} {
 	parameters := operation.Parameters
 	if parameters == nil {
 		return nil
@@ -76,7 +76,7 @@ func generateParameterSchema(operation *openapi3.Operation) *[]map[string]interf
 		}
 	}
 
-	return &result
+	return result
 }
 
 // generateBodySchema returns the given schema if there is one, a generated
@@ -108,7 +108,7 @@ func generateBodySchema(operation *openapi3.Operation) string {
 
 // generateContentTypes returns an array of allowed content types. nil if none.
 // Returned array will be sorted by name for deterministic comparisons.
-func generateContentTypes(operation *openapi3.Operation) *[]string {
+func generateContentTypes(operation *openapi3.Operation) []string {
 	requestBody := operation.RequestBody
 	if requestBody == nil {
 		return nil
@@ -136,7 +136,7 @@ func generateContentTypes(operation *openapi3.Operation) *[]string {
 	}
 	sort.Strings(list)
 
-	return &list
+	return list
 }
 
 // generateValidatorPlugin generates the validator plugin configuration, based