fix(o2k): create leaner config by using service level oidc #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since oidc is typically authorized at operation level, it was generated per route. But for cases where there is only 1 it would generate many similar configs per path. Now it creates 1 on the service, and ONLY deviating ones per route
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
==========================================
- Coverage 69.50% 69.48% -0.03%
==========================================
Files 17 17
Lines 2571 2579 +8
==========================================
+ Hits 1787 1792 +5
- Misses 652 655 +3
Partials 132 132 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since oidc is typically authorized at operation level, it was generated per route. But for cases where there is only 1 it would generate many similar configs per path.
Now it creates 1 on the service, and ONLY deviating ones per route