Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(o2k): param-explode default true if form style #186

Merged
merged 2 commits into from
Jul 12, 2024
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jul 12, 2024

"explode" defaulted to false.
When the style is "form" the "explode" default is now true, in all
other cases false.

OAS ref: https://swagger.io/specification/v3/#parameter-object (2nd table in this paragraph)

FTI-6088

"explode" defaulted to false.
When the style is "form" the "explode" default is now true, in all
other cases false.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 67.77%. Comparing base (b151569) to head (be5fe2a).

Files Patch % Lines
openapi2kong/validator.go 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
+ Coverage   67.76%   67.77%   +0.01%     
==========================================
  Files          23       23              
  Lines        2491     2492       +1     
==========================================
+ Hits         1688     1689       +1     
  Misses        643      643              
  Partials      160      160              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tieske Tieske merged commit 95d22e8 into main Jul 12, 2024
3 checks passed
@Tieske Tieske deleted the fix/param-explode branch July 12, 2024 06:41
GGabriele added a commit to Kong/deck that referenced this pull request Aug 5, 2024
Prashansa-K pushed a commit to Kong/deck that referenced this pull request Aug 5, 2024
Prashansa-K added a commit to Kong/deck that referenced this pull request Aug 19, 2024
* chore: bump go-apiops to v0.1.35

Ref: Kong/go-apiops#186

* chore: downgrade kin-openapi to v0.108.0 to maintain compatibility with go-apiops

* chore: go sum added for dprtaso/go-yit

---------

Co-authored-by: Prashansa Kulshrestha <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants