fix: parameter.required field coming as nil #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With recent deck changes that attemp to skip filling defaults before sending to CP, the cmd deck file openapi2kong had issues with the required field coming up as null, if it was not filled by the user. With this change, we fill it with false by default. Fixes: #203
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 68.19% 68.15% -0.05%
==========================================
Files 24 24
Lines 2550 2553 +3
==========================================
+ Hits 1739 1740 +1
- Misses 643 644 +1
- Partials 168 169 +1 ☔ View full report in Codecov by Sentry. |
|
@GGabriele Could you please check this PR? |
GGabriele
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With recent deck changes that attemp to skip
filling defaults before sending to CP, the cmd
deck file openapi2kong had issues with the required field coming up as null, if it was not filled by
the user. With this change, we fill it with
false by default.
Fixes: #203