feat: added support for path-params outside methods for request-validation #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation. This change allows the deck file openapi2kong command to create request validation configuration for path parameters directly under a route, not nested under an operation/method. Till now, we supported path parameters nested under a method. Fixes: #207
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #216 +/- ##
==========================================
+ Coverage 68.15% 69.08% +0.93%
==========================================
Files 24 24
Lines 2553 3290 +737
==========================================
+ Hits 1740 2273 +533
- Misses 644 848 +204
Partials 169 169 ☔ View full report in Codecov by Sentry. |
Tieske
requested changes
Oct 23, 2024
openapi2kong/oas3_testfiles/18-request-validator-plugin-path-params-outside-ops.yaml
Show resolved
Hide resolved
openapi2kong/oas3_testfiles/18-request-validator-plugin-path-params-outside-ops.yaml
Show resolved
Hide resolved
prioritise operation param
Tieske
requested changes
Oct 25, 2024
openapi2kong/oas3_testfiles/19-request-validator-plugin-op-params-override-path-params.yaml
Outdated
Show resolved
Hide resolved
Tieske
reviewed
Oct 28, 2024
| ], | ||
| "name": "example_test-common-param-common-param_get", | ||
| "paths": [ | ||
| "~/test/common-param/(?\u003ccommon_param\u003e[^#?/]+)$" |
There was a problem hiding this comment.
at some point the output switched to escaping the curly braces here, after I updated the underlying lib version. This script: https://github.com/Kong/go-apiops/blob/main/openapi2kong/oas3_testfiles/_fixup_expected.sh can be used to fix those.
Tieske
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the deck file openapi2kong command to create request validation configuration for path parameters directly under a route, not nested under an operation/method. Till now, we supported path parameters nested under a method.
Fixes: #207