Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tags): the entitylist for tags was missing acl-groups #89

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Sep 21, 2023

The format used here is deck specific. It is a table that handles many-to-many relationships; consumers <-> groups. Hence the group name is wrapped in an object to be able to assign tags.

JIRA: https://konghq.atlassian.net/browse/FTI-5286

The format used here is deck specific. It is a table that handles
many-to-many relationships; consumers <-> groups. Hence the group
name is wrapped in an object to be able to assign tags.
@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (88f95de) 69.19% compared to head (12421bf) 69.19%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   69.19%   69.19%           
=======================================
  Files          17       17           
  Lines        2376     2376           
=======================================
  Hits         1644     1644           
  Misses        613      613           
  Partials      119      119           
Files Changed Coverage Δ
deckformat/entitypointers.go 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tieske Tieske merged commit beea7a3 into main Sep 21, 2023
2 checks passed
@Tieske Tieske deleted the fix/acl-tags branch September 21, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants