fix(oas): align generated names with inso naming #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Names generated were slightly different from the names generated by Inso. This lines them up. This is however not 100% acurate. Inso had an issue with generating duplicate names if there were 2 identical paths, with and without trailing slash (/). So here we add "~" as indicator of a trailing slash. Other differences might be in the way non-english characters are slugified. Things like; "北京kožušček"
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
=========================================
+ Coverage 0 69.32% +69.32%
=========================================
Files 0 17 +17
Lines 0 2386 +2386
=========================================
+ Hits 0 1654 +1654
- Misses 0 613 +613
- Partials 0 119 +119
☔ View full report in Codecov by Sentry. |
Tieske
added a commit
that referenced
this pull request
Sep 29, 2023
Names generated were slightly different from the names generated by Inso. This lines them up. This is however not 100% acurate. Inso had an issue with generating duplicate names if there were 2 identical paths, with and without trailing slash (/). So here we add "~" as indicator of a trailing slash. Other differences might be in the way non-english characters are slugified. Things like; "北京kožušček"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Names generated were slightly different from the names generated
by Inso. This lines them up.
This is however not 100% acurate. Inso had an issue with generating
duplicate names if there were 2 identical paths, with and without
trailing slash (/). So here we add "~" as indicator of a trailing
slash. Other differences might be in the way non-english characters
are slugified. Things like; "北京kožušček"