Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ca_certificates): make ca_certificates cert referenceable #13834

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

windmgc
Copy link
Member

@windmgc windmgc commented Nov 5, 2024

Summary

This PR makes the cert field of the ca_certificates entity referenceable.

The ca_certificates entity has a cert_digest field which is calculated by transformation on_write functions. For referenced CA certs we cannot calculate the cert_digest when writing the entity to the database, because the entity creation always happens on CP and CP may not be able to dereference a secret. Therefore, the PR changed the behavior that if a referenced cert value is being used to create a ca_certificate entity, the cert digest must be manually provided too, otherwise it will not pass the entity check.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix https://konghq.atlassian.net/browse/FTI-6231

@github-actions github-actions bot added core/db schema-change-noteworthy cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Nov 5, 2024
@windmgc windmgc force-pushed the feat-ref-ca-certificate branch 3 times, most recently from 0ccad69 to 058266a Compare November 5, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db schema-change-noteworthy size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant