Skip to content

Conversation

@ProBrian
Copy link
Contributor

@ProBrian ProBrian commented Jun 6, 2025

Summary
Fix the prometheus plugin flaky test cases on AI metrics.

Root Cause:
AI metrics latency are floor evaluation, which means it could be 0, but AI metrics latency histogram only observe when latency is larger than 0, which may lead to missing increment of histogram.

Solution:

  1. like other non-AI latency histogram, latency 0 should also be observed.
  2. for test cases, Add waiting logic to wait the new latency calculation done.

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix KAG-7113

@github-actions github-actions bot added plugins/prometheus cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 6, 2025
@ProBrian ProBrian added skip-changelog and removed cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jun 6, 2025
Copy link
Member

@Oyami-Srk Oyami-Srk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consumer inside the bucket is missing for busted tests, is this expected?

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jun 9, 2025
@ADD-SP ADD-SP merged commit b7ab58b into master Jun 16, 2025
50 of 52 checks passed
@ADD-SP ADD-SP deleted the fix/prometheus-flaky branch June 16, 2025 02:50
github-actions bot pushed a commit that referenced this pull request Jun 16, 2025
@team-gateway-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants