Skip to content

Conversation

@yankun-li-kong
Copy link
Contributor

@yankun-li-kong yankun-li-kong commented Dec 7, 2021

Add a new parameter span_include_path to decide whether to include http path to span name.
Add test case.

Summary

This PR is based on Kong/kong-plugin-zipkin#124, Thanks @XinweiLiu28
Able to include HTTP path to span name for zipkin plugin

Full changelog

Add a new parameter span_include_path to decide whether to include HTTP path to span name.
Add test case.

Issues resolved

Fix FTI-2842

Add a new parameter span_include_path to decide whether to include http path to span name.
Add test case.
@mayocream
Copy link
Contributor

I think it is good to have the endpoint in Span name, see OpenTelemetry spec opentelemetry-specification/api.md at main · open-telemetry/opentelemetry-specification

For example, here are potential span names for an endpoint that gets a hypothetical account information:

Span Name Guidance
get Too general
get_account/42 Too specific
get_account Good, and account_id=42 would make a nice Span attribute
get_account/{accountId} Also good (using the "HTTP route")

@mayocream mayocream self-assigned this Feb 9, 2022
@kikito
Copy link
Member

kikito commented Mar 25, 2022

This looks ok to me. Could you please include a line on the changelog before merging it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants