-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GKE E2E tests and use (actual) E2E tests to gate releases #3035
Conversation
Convert tests other than the webhook tests to the new E2E environment helper. Refactor image loads to always succeed during builder construction.
397ad9c
to
eeb615e
Compare
Co-authored-by: Grzegorz Burzyński <[email protected]>
Discovered fun facts about environment notifications and the current E2E test job layout. 500+ low-content notifications in the timeline, very useful. https://github.com/Kong/kubernetes-ingress-controller/actions/runs/3424207046/jobs/5703617497 is the latest run with the changes to accept and use a (single value) matrix. This also mitigates an unrelated bug in the Makefile that I can't and don't really want to figure out:
I originally copied the target from the existing GKE target, which appears to be broken. |
Consolidate E2E environment builders into helper. Add GKE support for E2E tests. Add GKE E2E workflow and make target. Refactor image loads to always succeed during builder construction. Change final release test from integration to E2E. Co-authored-by: Grzegorz Burzyński <[email protected]>
What this PR does / why we need it:
Uses the E2E tests as the release job condition for creating the release tagnot yet, currently just a test variant because I can't easily test with the release workflow.We need this because we aren't currently running the test suite we want to during releases. It also requires some refactoring of the E2E tests themselves, which is a good opportunity to refactor them and KTF to address some ease of use issues. Tests cannot easily load cluster-specific functionality (loading images, adding a KIND configuration, etc.) without abusing the environment addon functionality (we have addons that fail if loaded on an unsupported cluster, which we don't want). Kong/kubernetes-testing-framework#403 seems an appropriate means of allowing for this.
Which issue this PR fixes:
Part of #2790
Fix #2287 (I think this actually got fixed earlier, but whatever, it's still open and this obsoletes it).
Fix #3041
Special notes for your reviewer:
We may want to make this permanent, but it's not the release job this eventually intends to be part of.I left it in for Add actions to run e2e/integration on k8s clusters of cloud providers #3041This draft only adopts the new system forTestDeployAllInOneDBLESS
. Pausing for any "wait, don't do it this way" comments before doing it for the rest.