-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): extract reusable workflows #3724
Conversation
1b3b478
to
ef514fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 👍
Couple of open ended questions for consideration
4ac3166
to
0b107d4
Compare
0b107d4
to
fecc8be
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #3724 +/- ##
========================================
- Coverage 73.6% 56.9% -16.7%
========================================
Files 133 133
Lines 15828 15828
========================================
- Hits 11651 9017 -2634
- Misses 3418 6191 +2773
+ Partials 759 620 -139 see 50 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢 🤞
@pmalek I pushed one more commit adding a |
This is a very good idea but hard to get right ;) We have to take into account PRs from forks (which is OK to not cover here because we have an issue tracking this) and also cancelled jobs. But let's take an iterative approach on this. 🙃 |
Co-authored-by: Patryk Małek <[email protected]>
Override merge since the checks pass, but Github won't let me say that they're the checks that should pass until they're merged 🐔 🥚 ♾️ |
What this PR does / why we need it:
Extracts parts of the existing workflows that are repeated across some of them (e.g.
_test_reports.yaml
), or encapsulates more complex parts into their own workflow so that they're easier to reason about in isolation (e.g._integration_tests.yaml
).All of the workflows that are extracted as reusable are named following the
_name.yaml
pattern to make them easily distinguishable.Runs of the affected top-level workflows:
Which issue this PR fixes:
Part of #3349.
It also enables E2E tests in the PR workflow as a part of #3725.
Special notes for your reviewer:
GH's docs on the reusable workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows
If we decide to accept this PR, we'll need someone with wider permissions set to change the required PR status checks, as the old ones are remaining stuck with
Waiting for status to be reported
.