-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump deck to v1.21.0 #4108
Conversation
Do we want to include some concrete (regression?) tests for Kong/deck#918 which 1.21 includes? 🤔 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4108 +/- ##
========================================
+ Coverage 60.3% 74.8% +14.5%
========================================
Files 150 150
Lines 16745 16745
========================================
+ Hits 10102 12534 +2432
+ Misses 6012 3434 -2578
- Partials 631 777 +146 ☔ View full report in Codecov by Sentry. |
Actually, that might be a good idea. Hold on, let me try to come up with something. |
@pmalek That was a fruitful journey that should allow us to make the upgrade tests more reliable as trying to trigger the regression I discovered some lacks of those:
|
I'm glad 😅 ... That we found those now, not e.g. after a release. 🎖️ Let's wait for #4117 to be merged then. |
@pmalek #4117 is ready for review. It triggers the upgrade condition in which |
E2E (targeted) tests were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/5145103305 |
|
@programmer04 Ahhh, it's again the problem with GKE E2E tests running against the nightly image 🤦 It will be fixed once we merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, it's good to go. 🟢
Btw. we should fix it, let's prfioritize Kong/kubernetes-testing-framework#587 or at least to some hack for GKE's e2e and triggered with label on PR to use image build from this PR @czeslavo
No description provided.