Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): fix setting GKE cluster version setting #4883

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Oct 18, 2023

What this PR does / why we need it:

Set the full version when selecting GKE cluster version in E2E tests.

This prevents issues like specifying 1.28.1 in test dependencies matrix

and then shortening it to 1.28.0 by not specifying the patch version via clusterBuilder.WithClusterMinorVersion()

@pmalek pmalek self-assigned this Oct 18, 2023
@pmalek pmalek requested a review from a team as a code owner October 18, 2023 09:18
@pmalek pmalek added ci/run-e2e Trigger e2e test run from PR and removed size/XS labels Oct 18, 2023
@team-k8s-bot
Copy link
Collaborator

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6558825930

@team-k8s-bot team-k8s-bot removed the ci/run-e2e Trigger e2e test run from PR label Oct 18, 2023
@pmalek pmalek enabled auto-merge (squash) October 18, 2023 09:27
@pmalek
Copy link
Member Author

pmalek commented Oct 18, 2023

E2E (targeted) tests with KIND-based clusters were started at https://github.com/Kong/kubernetes-ingress-controller/actions/runs/6558825930

I forgot that we don't run e2e tests because we don't have image loading implemented for that cluster provider Kong/kubernetes-testing-framework#587 🤦

@pmalek pmalek merged commit a93d720 into main Oct 18, 2023
193 checks passed
@pmalek pmalek deleted the fix-e2e-gke-cluster-version branch October 18, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants