chore(linter): in switch case default signifies exhaustive match and …

…fix forbidigo (#850)
Kong · Oct 25, 2023 · 331bf79 · 331bf79
1 parent 2a827a3
commit 331bf79
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.golangci.yaml b/.golangci.yaml
@@ -35,6 +35,8 @@ linters:
   - wastedassign
 
 linters-settings:
+  exhaustive:
+    default-signifies-exhaustive: true
   gci:
     sections:
     - standard
@@ -82,7 +84,7 @@ linters-settings:
       - pkg: sigs.k8s.io/gateway-api/apis/(v[\w\d]+)
         alias: gateway${1}
   forbidigo:
-    exclude_godoc_examples: false
+    exclude-godoc-examples: false
     forbid:
       - 'CoreV1\(\)\.Endpoints(# use DiscoveryV1 EndpointSlices API instead)?'
       - 'corev1\.Endpoint(# use DiscoveryV1 EndpointSlices API instead)?'

diff --git a/pkg/clusters/addons/kong/addon.go b/pkg/clusters/addons/kong/addon.go
@@ -628,7 +628,7 @@ func urlForService(ctx context.Context, cluster clusters.Cluster, nsn types.Name
 		return nil, err
 	}
 
-	switch service.Spec.Type { //nolint:exhaustive
+	switch service.Spec.Type {
 	case corev1.ServiceTypeLoadBalancer:
 		if len(service.Status.LoadBalancer.Ingress) == 1 {
 			return url.Parse(fmt.Sprintf("http://%s:%d", service.Status.LoadBalancer.Ingress[0].IP, port))

diff --git a/pkg/clusters/addons/kong/builder.go b/pkg/clusters/addons/kong/builder.go
@@ -86,14 +86,15 @@ func (b *Builder) Build() *Addon {
 	}
 
 	// LoadBalancer is used by default for historical and convenience reasons.
-	switch b.proxyServiceType { //nolint:exhaustive
+	switch b.proxyServiceType {
 	case "":
 		b.proxyServiceType = corev1.ServiceTypeLoadBalancer
 	case corev1.ServiceTypeNodePort:
 		// If the proxy service type is NodePort, then set the default proxy NodePort.
 		if b.httpNodePort == 0 {
 			b.httpNodePort = DefaultProxyNodePort
 		}
+	default:
 	}
 
 	return &Addon{