Skip to content

Commit

Permalink
fix: use correct command for describe (#343)
Browse files Browse the repository at this point in the history
  • Loading branch information
rainest committed Aug 5, 2022
1 parent ecd4b3e commit 648fcc8
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,16 +3,23 @@
## v0.19.0

### Added

- Added feature to support waiting for a port of a service to be connective
by TCP.
[#338](https://github.com/Kong/kubernetes-testing-framework/pull/338)

### Improved

- Increased retry times to increase the timeout to wait for kuma webhook
to be ready to serve.
[#341](https://github.com/Kong/kubernetes-testing-framework/pull/341)
[#342](https://github.com/Kong/kubernetes-testing-framework/pull/342)

### Fixed

- Diagnostics runs the correct command for `kubectl describe`.
[#343](https://github.com/Kong/kubernetes-testing-framework/pull/343)

## v0.18.0

### Added
Expand Down
2 changes: 1 addition & 1 deletion pkg/clusters/cleanup.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func (c *Cleaner) DumpDiagnostics(ctx context.Context, meta string) (string, err
if err != nil {
return output, err
}
cmd = exec.CommandContext(ctx, "kubectl", "--kubeconfig", kubeconfig.Name(), "get", "all", "--all-namespaces", "-o", "yaml") //nolint:gosec
cmd = exec.CommandContext(ctx, "kubectl", "--kubeconfig", kubeconfig.Name(), "describe", "all", "--all-namespaces") //nolint:gosec
cmd.Stdout = describeAllOut
if err := cmd.Run(); err != nil {
return output, err
Expand Down

0 comments on commit 648fcc8

Please sign in to comment.