Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove myself from CODEOWNERS #1111

Closed
wants to merge 1 commit into from
Closed

chore: remove myself from CODEOWNERS #1111

wants to merge 1 commit into from

Conversation

shaneutt
Copy link
Contributor

@shaneutt shaneutt commented Jul 4, 2024

remove myself from CODEOWNERS

@shaneutt shaneutt requested a review from a team as a code owner July 4, 2024 12:36
pmalek
pmalek approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

@shaneutt
Copy link
Contributor Author

shaneutt commented Jul 5, 2024

stuck?

@pmalek
Copy link
Member

pmalek commented Jul 5, 2024

Error when evaluating 'timeout-minutes' for job 'setup-e2e-tests'. .github/workflows/tests.yaml (Line: 166, Col: 22): Error parsing fromJson,.github/workflows/tests.yaml (Line: 166, Col: 22): Error reading JToken from JsonReader. Path '', line 0, position 0.,.github/workflows/tests.yaml (Line: 166, Col: 22): Unexpected value ''Show less

kubernetes-testing-framework/.github/workflows/tests.yaml

Line 166 in ce7152d

timeout-minutes: ${{ fromJSON(vars.GHA_DEFAULT_TIMEOUT) }}

I believe the problem might be related to this PR being from a fork and in that context we don't have access to org's variables. Can you try to repush this from a branch in the repo?

@shaneutt shaneutt closed this Jul 5, 2024
@shaneutt shaneutt deleted the patch-1 branch July 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek pmalek pmalek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shaneutt @pmalek