ci: use gh in install.sh for artifacts download

[pmalek]

This PR aims to avoid hitting the API rate limiting by using gh which should already be using GITHUB_TOKEN on Github's CI.

[codecov-commenter]

Codecov Report

Base: 53.78% // Head: 53.88% // Increases project coverage by +0.10% 🎉

Coverage data is based on head (88a37b0) compared to base (f41d719).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
+ Coverage   53.78%   53.88%   +0.10%     
==========================================
  Files          50       50              
  Lines        3901     3901              
==========================================
+ Hits         2098     2102       +4     
+ Misses       1543     1539       -4     
  Partials      260      260              

Flag	Coverage Δ
integration-test	58.86% <ø> (+0.11%)	⬆️
unit-test	3.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
pkg/clusters/utils.go	51.86% <0.00%> (+1.65%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[shaneutt]

Let's just make sure we add helpful output if a user uses this script but doesn't have gh installed to go install it, and then test it on our supported platforms, then LGTM 👍

[pmalek]

Let's just make sure we add helpful output if a user uses this script but doesn't have gh installed to go install it, and then test it on our supported platforms, then LGTM 👍

Thanks for the suggestion: I ended up testing this on Mac arm64 and Linux aarch64 (as reported by uname) alpine image. This needed some changes.

PTAL.

[shaneutt]

Looks OK, just as long as we test before merging.

I would also ask if we haven't already, we should create some automated tests for this installer and to exercise the CLI to ensure we're not breaking the CLI and its installer on updates. If we could at minimum create a follow-up issue for that, and manually test now that would be good 👍

[pmalek]

I've added a very simple installer test: example run: https://github.com/Kong/kubernetes-testing-framework/actions/runs/4076445875/jobs/7024196104#step:3:10

Plus: as noted above I've tested it manually which should do for now. The old behaviour of downloading via curl stays, so there shouldn't ™️ be any surprises there.

PTAL.

[pmalek]

Force merging because @shaneutt is not a member of team required to approve PRs in this repo 🤷

edit: shaneutt retroactively added to CODEOWNERS as per 8f02401

[mflendrich]

What is the purpose of --help here? 🤔

if the purpose is to validate that the ktf binary is present, please (at least) comment about the intent behind using --help in an automated workflow

[mflendrich]

nit: inconsistent quotes around arch names "arm64" vs aarch64 in lines 37 and 33 respectively