Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(analytics-utilities): drop docs build script #1690

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

docs(analytics-utilities): drop docs build script #1690

wants to merge 2 commits into from

Conversation

mihai-peteu
Copy link
Contributor

@mihai-peteu mihai-peteu commented Oct 3, 2024 •
edited
Loading

Summary

adamdehaven
adamdehaven reviewed Oct 4, 2024
View reviewed changes
packages/analytics/analytics-utilities/package.json Outdated
@@ -23,7 +23,7 @@
"scripts": {
"dev": "cross-env USE_SANDBOX=true vite",
"build": "run-s typecheck build:package build:types",
"build:docs": "typedoc --plugin typedoc-plugin-markdown --out docs src/index.ts --entryDocument analytics-utils.md --gitRevision main --githubPages false --readme none --tsconfig ./tsconfig.build.json",
"build:docs": "typedoc --plugin typedoc-plugin-markdown --out docs src/index.ts --gitRevision main --githubPages false --readme none --tsconfig ./tsconfig.build.json",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than a pre-commit hook, could you just add the build:docs script at the end of the build script above?

@mihai-peteu mihai-peteu changed the title docs(analytics-utilities): update docs build script docs(analytics-utilities): drop docs build script Oct 4, 2024
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/analytics-utilities@pr-1690
@kong-ui-public/analytics-chart@pr-1690
@kong-ui-public/analytics-config-store@pr-1690
@kong-ui-public/analytics-geo-map@pr-1690
@kong-ui-public/portal-analytics-bridge@pr-1690
@kong-ui-public/analytics-metric-provider@pr-1690
@kong-ui-public/dashboard-renderer@pr-1690

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven left review comments

@kongponents-bot kongponents-bot Awaiting requested review from kongponents-bot kongponents-bot will be requested when the pull request is marked ready for review kongponents-bot is a code owner

@ValeryG ValeryG Awaiting requested review from ValeryG ValeryG will be requested when the pull request is marked ready for review ValeryG is a code owner

@jillztom jillztom Awaiting requested review from jillztom jillztom will be requested when the pull request is marked ready for review jillztom is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihai-peteu @kongponents-bot @adamdehaven