Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(entity-base-table): fix missing prop warning #1776

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TT1228
Copy link
Contributor

@TT1228 TT1228 commented Nov 11, 2024

Summary

Defining preferencesStorageKey cause missing prop warning in console. Since preferencesStorageKey has a default value, it can be removed.

@TT1228 TT1228 requested review from a team as code owners November 11, 2024 06:55
@kongponents-bot
Copy link
Collaborator

Preview components from this PR in consuming application

In consuming application project install preview versions of shared packages generated by this PR:

@kong-ui-public/entities-shared@pr-1776
@kong-ui-public/dashboard-renderer@pr-1776
@kong-ui-public/documentation@pr-1776
@kong-ui-public/entities-certificates@pr-1776
@kong-ui-public/entities-consumer-credentials@pr-1776
@kong-ui-public/entities-consumer-groups@pr-1776
@kong-ui-public/entities-consumers@pr-1776
@kong-ui-public/entities-data-plane-nodes@pr-1776
@kong-ui-public/entities-gateway-services@pr-1776
@kong-ui-public/entities-key-sets@pr-1776
@kong-ui-public/entities-keys@pr-1776
@kong-ui-public/entities-routes@pr-1776
@kong-ui-public/entities-snis@pr-1776
@kong-ui-public/entities-upstreams-targets@pr-1776
@kong-ui-public/entities-vaults@pr-1776
@kong-ui-public/entities-plugins@pr-1776

Copy link
Member

@Leopoldthecoder Leopoldthecoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants