Skip to content

test(viewer): session-ledger envelope crypto proptest surface (WBS-6.2 #474) - #494

Closed
KooshaPari wants to merge 0 commit into
mainfrom
fix/viewer-envelope-crypto-properties-20260809
Closed

test(viewer): session-ledger envelope crypto proptest surface (WBS-6.2 #474)#494
KooshaPari wants to merge 0 commit into
mainfrom
fix/viewer-envelope-crypto-properties-20260809

Conversation

@KooshaPari

@KooshaPari KooshaPari commented Aug 11, 2026

Copy link
Copy Markdown
Owner

User description

WBS-6.2 surface 14: session-ledger soft envelope.

Branch off fix/viewer-mock-data-properties-20260809 rebased main. Test file compiles and passes locally.


CodeAnt-AI Description

Add property coverage for session-ledger envelope encryption

What Changed

  • Added randomized tests confirming encrypted data can be sealed and reopened for empty, single-byte, and arbitrary binary content
  • Added checks for the documented v1 envelope format, deterministic output, and key configuration
  • Added failure coverage for missing or incorrectly sized keys and malformed envelope data
  • Recorded the new coverage in the changelog, WBS evidence, and traceability documentation

Impact

✅ Fewer regressions in session-ledger secret storage
✅ Clearer failures for invalid keys and corrupted envelopes
✅ Verified compatibility with the documented v1 envelope format

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Copilot AI lite review requested due to automatic review settings August 11, 2026 00:06
@codeant-ai

codeant-ai Bot commented Aug 11, 2026

Copy link
Copy Markdown

🤖 CodeAnt AI — Review Status

Status Commit Started (UTC) Finished (UTC)
✅ Incremental review completed b0b0a87 Aug 12, 2026 · 08:21 08:22
✅ Reviewed your PR ba2c2da Aug 11, 2026 · 00:06 00:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@codeant-ai

codeant-ai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@KooshaPari, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 12 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: d13e9c03-49a0-4a4f-8be7-e29b8d91a5fc

📥 Commits

Reviewing files that changed from the base of the PR and between f445859 and b0b0a87.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • crates/sl-viewer/tests/properties_session_ledger_envelope.rs
  • docs/ops/TRACEABILITY.json
  • docs/ops/WBS.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai codeant-ai Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files label Aug 11, 2026
KooshaPari pushed a commit that referenced this pull request Aug 12, 2026
…#474)

Shards the unique viewer proptest from #494 onto main without the
obsolete pre-rename daemon source churn.
@KooshaPari
KooshaPari force-pushed the fix/viewer-envelope-crypto-properties-20260809 branch from ba2c2da to b0b0a87 Compare August 12, 2026 08:21
@codeant-ai

codeant-ai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added size:L This PR changes 100-499 lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Aug 12, 2026
@KooshaPari KooshaPari closed this Aug 12, 2026
@KooshaPari
KooshaPari force-pushed the fix/viewer-envelope-crypto-properties-20260809 branch from b0b0a87 to f445859 Compare August 12, 2026 08:24
@KooshaPari
KooshaPari deleted the fix/viewer-envelope-crypto-properties-20260809 branch August 12, 2026 08:38
@kilo-code-bot

kilo-code-bot Bot commented Aug 12, 2026

Copy link
Copy Markdown

Code Review Summary

Status: No Issues Found | Recommendation: N/A (PR Closed, No Changes)

Files Reviewed (0 files)

Reviewed by step-3.7-flash · Input: 64.1K · Output: 4.5K · Cached: 158.6K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants