Skip to content

fix(ci): use fresh viewer artifact for browser contracts #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
KooshaPari wants to merge 1 commit into from
Closed

fix(ci): use fresh viewer artifact for browser contracts #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/a11y.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,9 @@ jobs:
tool: dioxus-cli@0.7.9
- name: Build sl-viewer web surface
working-directory: crates/sl-viewer
run: dx build --platform web --release --no-default-features --features web
# Avoid dx 0.7.9's release wasm-opt SIGABRT; validate a fresh debug
# web artifact rather than falling through to stale output.
run: dx build --platform web --debug-symbols false --no-default-features --features web
- name: Install harness dependencies
run: npm ci
- name: Install Chromium
Expand Down
11 changes: 5 additions & 6 deletions .github/workflows/qgate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,12 +124,11 @@ jobs:
tool: dioxus-cli@0.7.9
- name: Build sl-viewer web surface
working-directory: crates/sl-viewer
# Binaryen bundled by dx 0.7.9 aborts when rewriting LLVM DWARF
# compile-unit metadata emitted by the pinned Rust toolchain. Release
# browser artifacts do not need DWARF (source maps are not shipped),
# so omit debug symbols and keep wasm-opt's production optimization
# pass enabled instead of accepting a non-deterministic SIGABRT.
run: dx build --platform web --release --debug-symbols false --no-default-features --features web
# Binaryen bundled by dx 0.7.9 aborts during its release wasm-opt pass
# with the pinned Rust/Dioxus toolchain. A debug web bundle is still a
# fresh, deterministic browser artifact and avoids silently testing a
# stale bundle after wasm-opt fails.
run: dx build --platform web --debug-symbols false --no-default-features --features web
- name: Install harness dependencies
run: npm ci
- name: Install Chromium
Expand Down
Loading