(Nested) typealias KDocs #1543
Open
(Nested) typealias KDocs #1543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pe-aliases in :core, saving 400KB of jar size
…pe-aliases in :dataframe-csv
Jolanrensen
added
KDocs
|
Very cool! |
# Conflicts: # core/src/main/kotlin/org/jetbrains/kotlinx/dataframe/documentation/DocumentationUrls.kt
|
just need to check notebooks etc don't have issues with nested typealiases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1423 by enabling nested type aliases and replacing all bodiless documentation interfaces with type aliases of
Nothing. Type aliases, compared to interfaces, are "transparent" in the JVM, as they don't exist in Java. This saves quite some bytes in the final jar.With this refactor, we save 400kB :)