-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Non-Blocking mark occurences #85
base: kotlin-1.3.0
Are you sure you want to change the base?
Conversation
@zarechenskiy, any news on this, can you merge it? |
Sorry for the long delay, @Kordyjan will review your PR |
I have no complaints about changes in code. |
Add delay to runJob method, make mark occurences cancellable
1261e3b
to
56d54de
Compare
1890757
to
ae3cd60
Compare
Hi, any news? Do you need some help? If you change the base branch to more recent one, I am willing to invest some time to resolve the inspections mentioned by @Kordyjan |
@noemus: Sadly we didn't have time and resources to fix it. It is on our to do list all the time, but it is constantly posponed by the things with higher priority. We are grateful for your engagement and help. If you have some time to spare it will definitely help us release it sooner. |
Any progress? |
Unfortunately I didn't have time to do anything I even no longer use eclipse so I would need to install it and configure it solely for this purpose. We will see, maybe I will have some spare time around Christmas. |
I made some changes to 'Mark occurences' task behaviour,
I am aware that these changes are not ideal, but the plugin was nearly unusable without them, every change in editor produced number of backround tasks. and even single task blocked eclipse more than necessary.
I removed synchronized section in KotlinPsiManager, I think that in this case responsivity is primary goal and I have used ConcurrentMaps to synchronize access to cached projects and kotlin files to improve performance, I am using this modified plugin for several months without serious problems and without blocking events like 'Update occurance annotations' background task.
I am not very experienced in opensource projects, so please forgive me if I have done something wrong, I will gladly learn how to do it properly.
https://discuss.kotlinlang.org/t/extremely-poor-performance-of-the-kotlin-plugin-for-eclipse/3397
NOTES: closed original pull request, synced to upstream and resolved conflicts, moved changes to dedicated branch. successfully built and tested.