Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-Blocking mark occurences #85

Open
wants to merge 14 commits into
base: kotlin-1.3.0
Choose a base branch
from

Conversation

noemus
Copy link

@noemus noemus commented Mar 28, 2018

I made some changes to 'Mark occurences' task behaviour,

I am aware that these changes are not ideal, but the plugin was nearly unusable without them, every change in editor produced number of backround tasks. and even single task blocked eclipse more than necessary.

I removed synchronized section in KotlinPsiManager, I think that in this case responsivity is primary goal and I have used ConcurrentMaps to synchronize access to cached projects and kotlin files to improve performance, I am using this modified plugin for several months without serious problems and without blocking events like 'Update occurance annotations' background task.

I am not very experienced in opensource projects, so please forgive me if I have done something wrong, I will gladly learn how to do it properly.

https://discuss.kotlinlang.org/t/extremely-poor-performance-of-the-kotlin-plugin-for-eclipse/3397

NOTES: closed original pull request, synced to upstream and resolved conflicts, moved changes to dedicated branch. successfully built and tested.

@jan-zajic
Copy link

@zarechenskiy, any news on this, can you merge it?

@zarechenskiy
Copy link
Contributor

Sorry for the long delay, @Kordyjan will review your PR

@Kordyjan
Copy link
Contributor

Kordyjan commented Sep 14, 2018

I have no complaints about changes in code.
After syncing this PR with current master branch and making it compile again I tested it on two machines. It indeed fixed problem with spawning unnecessary tasks and improved responsivness of plugin, especially on the slower machine.
However this change is breaking some minor inspections, like finding excess braces in kotlin files. I still haven't find the reason why. As soon as I fix it i will create new pull request.

@Kordyjan Kordyjan changed the base branch from master to kotlin-1.3.0 October 8, 2018 10:43
noemus and others added 2 commits October 8, 2018 14:29
Add delay to runJob method, make mark occurences cancellable
@noemus
Copy link
Author

noemus commented Jul 20, 2019

Hi, any news? Do you need some help? If you change the base branch to more recent one, I am willing to invest some time to resolve the inspections mentioned by @Kordyjan

@Kordyjan
Copy link
Contributor

@noemus: Sadly we didn't have time and resources to fix it. It is on our to do list all the time, but it is constantly posponed by the things with higher priority. We are grateful for your engagement and help. If you have some time to spare it will definitely help us release it sooner.

@UdoW
Copy link

UdoW commented Nov 12, 2020

Any progress?

@noemus
Copy link
Author

noemus commented Nov 20, 2020

Unfortunately I didn't have time to do anything I even no longer use eclipse so I would need to install it and configure it solely for this purpose. We will see, maybe I will have some spare time around Christmas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants