Remove deprecated APIs usage and enable warning-as-errors for build scripts #2925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should force to update build scripts on any new deprecation introduced in the used plugins.
This should force to update scripts on new deprecation introduced in the plugins.
Only IR compiler available now.
Tapchicoma
commented
Feb 10, 2025
| @@ -45,6 +45,7 @@ kotlin { | |||
| watchosDeviceArm64() | |||
|
|
|||
| // Deprecated, but not removed | |||
| @Suppress("DEPRECATION") | |||
There was a problem hiding this comment.
I am not sure this target support is required and maybe we just could remove it?
There was a problem hiding this comment.
Yes, it is required for one of our customers
sandwwraith
reviewed
Feb 10, 2025
| @@ -45,6 +45,7 @@ kotlin { | |||
| watchosDeviceArm64() | |||
|
|
|||
| // Deprecated, but not removed | |||
| @Suppress("DEPRECATION") | |||
There was a problem hiding this comment.
Yes, it is required for one of our customers
| compilerOptions { | ||
| jvmTarget.set(JvmTarget.JVM_9) | ||
| // To support LV override when set in aggregate builds | ||
| languageVersion.set(compileTask.compilerOptions.languageVersion) |
There was a problem hiding this comment.
Why did you remove LV + optIns copying? IIRC lack of proper LV caused some problems in aggregate/user projects builds.
|
Also, PTAL on Kotlin master build failure. It seems we can't turn -Werror on builds while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.